topaz-next / topaz

💎 A server emulator for Final Fantasy XI.
GNU General Public License v3.0
56 stars 81 forks source link

Merit fix for GEO and previous crash #2502

Closed Omnione closed 3 years ago

Omnione commented 3 years ago

Made the merit categories more human readable by adding the category numbers on each one.

removed the duplicate category left from before.

added rune fencer merit categories to status.lua.

Just to go over a previous convo about what the if statement was doing with seemingly random numbers,

this part will add the categories that are unknown, as other wise the check in the first part will not add them, so cat 27,28,29,31 and 51 will be added even though they don't have any merits associated with them they need to be added or we can not iterate over the merits.

if ((catNumber <= maxCatCount && i == meritNameSpace::groupOffset[catNumber]) || (catNumber > 26 && catNumber < 31) || catNumber == 51)

this part takes the unknown merit categories and just points them to a valid merit category so it wont crash.

if ((catNumber > 26 && catNumber < 31) || catNumber == 51)

I affirm:

Temporary: