topaz-next / topaz

💎 A server emulator for Final Fantasy XI.
GNU General Public License v3.0
56 stars 81 forks source link

[canary] Issue on treasure chest #2534

Closed Chronos77 closed 3 years ago

Chronos77 commented 3 years ago

Additional Information (Steps to reproduce/Expected behavior) : Resolve treasure chest after kill a mob image

Xaver-DaRed commented 3 years ago

In short, the issue is... it told you the "first digit" when it should have been the "second digit" OR it showed a 0 when it should have been a 2 (First digit cannot be 0 ever)

First case could be caused by a textID missmatch. Knowing wich zone you were in and if it happens in other zones and your client version might help.

Chronos77 commented 3 years ago

Hi, i'm in kuftal tunnel, i will try in another zone . image

Chronos77 commented 3 years ago

Same in West Sarutabaruta

image

Xaver-DaRed commented 3 years ago

So in short, now we know that its returning a 0 instead of the actual number. And it seems like it is the correct number that is being turned to a 0

wrenffxi commented 3 years ago

My guess is the problem is that splitNumbers[1] is string. Probably needs change from

                        player:messageSpecial(baseMessage + casketInfo.messageOffset.FIRST_DIGIT_IS,
                            splitNumbers[1],
                            splitNumbers[1] +1,
                            splitNumbers[1] +2, 0)

to

                        player:messageSpecial(baseMessage + casketInfo.messageOffset.FIRST_DIGIT_IS,
                            splitNumbers[1] +0,
                            splitNumbers[1] +1,
                            splitNumbers[1] +2, 0)

wherever it's being passed as argument into messageSpecial will fix tomorrow if nobody beats me to it

Chronos77 commented 3 years ago

It's works! image