Third Eye and Utsusemi should not stack.

[gweivyth]

I affirm:

• [x] that I agree to Topaz Next's Limited Contributor License Agreement, as written on this date
• [x] that I have read the Contributing Guide and the Code of Conduct
• [x] that I've tested my code since the last commit in the PR, and will test after any later commits

Temporary:

• [x] that I understand there are large refactoring efforts going on right now, that these efforts touch every single Lua script and binding, and that my pull request might get put on hold to ensure there are not any conflicts with the refactoring work

Above image taken from retail. These effects shouldn't stack. Copy Image should wipe Third Eye, and Third Eye should have no effect when player is under the effect of Copy Image.

[Xaver-DaRed]

Tabs need to be converted to 4 spaces/formating, in general. I would also edit utsusemi_san, becouse theres no reason for it not removing third eye aswell if ichi and ni do. Sent you a DM to discord with the formated files

[gweivyth]

I totally blanked on San even existing cause of 75-brain, added the formatting you sent and the update for San as well, thanks!

[zach2good]

EDIT: Ah, yes, I can read. Ignore everything below. Third eye is the thing being cancelled!

Is checking for tpz.effect.COPY_IMAGE enough? I say this because on retail when my gearswap checks for and cancels shadows, I have to check for 4 things:

    -- Cancel Shadows
    if spell.english == "Utsusemi: Ichi" then
        if buffactive['Copy Image'] then
            send_command('@wait 2.2; cancel 66')
        elseif buffactive['Copy Image (2)'] then 
            send_command('@wait 2.2; cancel 444')
        elseif buffactive['Copy Image (3)'] then
            send_command('@wait 2.2; cancel 445')
        elseif buffactive['Copy Image (4+)'] then
            send_command('@wait 2.2; cancel 446')
        end
    end

[TeoTwawki]

EDIT: Ah, yes, I can read. Ignore everything below. Third eye is the thing being cancelled!

Is checking for tpz.effect.COPY_IMAGE enough? I say this because on retail when my gearswap checks for and cancels shadows, I have to check for 4 things:

    -- Cancel Shadows
  if spell.english == "Utsusemi: Ichi" then
      if buffactive['Copy Image'] then
          send_command('@wait 2.2; cancel 66')
      elseif buffactive['Copy Image (2)'] then 
          send_command('@wait 2.2; cancel 444')
      elseif buffactive['Copy Image (3)'] then
          send_command('@wait 2.2; cancel 445')
      elseif buffactive['Copy Image (4+)'] then
          send_command('@wait 2.2; cancel 446')
      end
    end

I believe the old ones cheated and used effect:setIcon() to use just one effect in reality while sending the correct effectID packets to the client to set the correct icon and tell the client "its multiple effects, honest!" in a similar manner to if we had used addStatusEffectEx().

[TeoTwawki]

Final commit.

Allegedly! :wink:

jokes aside safest to be descriptive even on short quick fixes, unless you intend to squash after.

[zach2good]

The content is there, but the formatting is off. I'll merge this into a branch and clean it up, then yeet it into release. Thanks for the contribution 👍