Appraisal and Assault - Githubissues

topaz-next / topaz

💎 A server emulator for Final Fantasy XI.

GNU General Public License v3.0

55 stars 81 forks source link

Appraisal and Assault #2569

Closed zach2good closed 3 years ago

zach2good commented 3 years ago

I affirm:

[x] that I agree to Topaz Next's Limited Contributor License Agreement, as written on this date
[x] that I have read the Contributing Guide and the Code of Conduct
[x] that I've tested my code since the last commit in the PR, and will test after any later commits

Temporary:

[x] that I understand there are large refactoring efforts going on right now, that these efforts touch every single Lua script and binding, and that my pull request might get put on hold to ensure there are not any conflicts with the refactoring work

Started work on porting Appraisal and Assault work from KO and Erri If you want any finer-grained authoring for the initial 2 commits, let me know here or on discord 🙏

repo: https://github.com/KnowOne134/DSP-Shared_Collection

Done

Configuring everything for sol_refactor
Changing all dsp things to tpz
Likely re-shifting IDs back to modern client IDs
Some formatting, but not much

Lots to do

Stashing the new global in tpz (nothing personal, just cleaner that way!)
Probably removing a bunch of Eden specific things!
Some testing. It's OK for these to be broken, as we're missing a lot of pieces