[x] that I've tested my code since the last commit in the PR, and will test after any later commits
Temporary:
[x] that I understand there are large refactoring efforts going on right now, that these efforts touch every single Lua script and binding, and that my pull request might get put on hold to ensure there are not any conflicts with the refactoring work
Three quests ...
Making Headlines
Hat in Hand
Forge Your Destiny
... were using custom bit-checking function called testflag() that was littered across many NPC scripts. This PR kills those testflag() functions, and instead uses the functions on utils.mask
I saw a lot of old code and some errors in related NPCs, so I modernizes all the NPC scripts that were involved. Changes include:
when clicking on the Mahogany Door during Making Headlines, add a textID for CAT_BURGLARS_HIDEOUT message, rather than a magic number which hadn't been kept current.
during Hat in Hand, add the "You show off your hat" message for the mandatory NPCs. Note that Hat in Hand is not retail accurate. In retail you have to show the hat to nearly every NPC in the zone to get the maximum reward. But that change is too big for this PR, which was already creeping toward annoying-to-review.
Hat in Hand is no longer repeatable (as of Sept 2010) so I removed its repeatability. Also, the Windshear Hat is now for sale at Orez-Ebrez.
add default dialog to Machitata.
when completing Hat in Hand, don't rely on option, which can be spoofed, to determine reward for Hat in Hand. Instead, I'm using player:setLocalVar.
during Forge Your Destiny, add a missing event param when re-purchasing Sacred Sprig from Ranemaud.
npcUtil-ify trades and quest completions.
For testing, I did a full run through of all three quests after making these changes.
I affirm:
Temporary:
Three quests ...
... were using custom bit-checking function called testflag() that was littered across many NPC scripts. This PR kills those testflag() functions, and instead uses the functions on utils.mask
I saw a lot of old code and some errors in related NPCs, so I modernizes all the NPC scripts that were involved. Changes include:
For testing, I did a full run through of all three quests after making these changes.