Skillup books - Githubissues

topaz-next / topaz

💎 A server emulator for Final Fantasy XI.

GNU General Public License v3.0

55 stars 80 forks source link

Skillup books #2659

Closed Omnione closed 3 years ago

Omnione commented 3 years ago

Added all skillup books and made them functional.

This has been tested thoroughly on Canaria when it was on Topaz.

Now its been redone for Topaz-Next refactor release.

I affirm:

[X] that I agree to Topaz Next's Limited Contributor License Agreement, as written on this date
[X] that I have read the Contributing Guide and the Code of Conduct
[X] that I've tested my code since the last commit in the PR, and will test after any later commits

Omnione commented 3 years ago

gonna leave this as a draft while we wait on Clays Pr, then ill get it changed to the trySkillUp()

Omnione commented 3 years ago

oh, need a new line on item_utils

ghost commented 3 years ago

Note to future self: Apparently book skillups can also affect sub-job skills. Need to adjust charutils::TrySkillUp and the binding to be able to support this.