topaz-next / topaz

💎 A server emulator for Final Fantasy XI.
GNU General Public License v3.0
55 stars 80 forks source link

Ranged weaponskills can proc double/triple/etc. attack. #2696

Open almuth150 opened 3 years ago

almuth150 commented 3 years ago

Additional Information (Steps to reproduce/Expected behavior) : I noticed that sometimes when you use a ranged WS, you can get weird damage/tp returns, so I did a bit of digging. In weaponskills.lua, the function doRangedWeaponskill calls upon calculateRawWSDmg, which calls upon getMultiAttacks. That last function is always called, and has no check for whether or not it's a ranged weaponskill. This should not be the case; ranged weaponskills should not get any extra hits from those traits.