topaz-next-bot
commented
3 years ago 
Additional thought: if SE ever allows those add effect augments to be applied to more than a handful of weapons, we'd need a generic (onAdditionalEffectEX? nothx) or individual scripts for all weapon (lolno) under the current system.
Despite currently scripted and in progress scripts for these I've been thinking maybe individually scripting every additional effect weapon in the game wasn't the best approach we could have taken to this. I know previously there were additional effect weapons hard coded in the core and am not advocating a return to that. But perhaps a method closer to spike effects via modifiers would be better for setting the effect type and potency / base dmg of the effect. Note that the spikes still allow scripting, and so far we've done monster spikes scripted and item spikes by modifier. Also: http://ffxiclopedia.wikia.com/wiki/Dweomer_Scythe There are additional effects granted via augments, which in our current system of full on scripting we could do as an extra modifier to check for in the scripts of the individual items. However, as mentioned in Darkstar Issue 2522 scripted additional effects presently ignore sync as well (I believe they shouldn't fire off at all if you are below the level of your weapon, and not a thing that scales down). That too, could be checked for in scripts. But maybe it'd be better to just have modifiers for the effect type and power that could then be directly set to the item via the augments. In the spikes code in core for items you can see the modifiers get set to the item, not the player, and checks per item. We could check for the player being below the weapons level right there one time to stop the proc, rather then repeatedly check for being sync'd below the weapons level in every onAdditionalEffect script.
So my long winded wall-o-text boils down to the question: Better to implement workarounds in scripts, or to change the underlying method?