search

topazproject / topaz

A high performance ruby, written in RPython
topazruby.com
BSD 3-Clause "New" or "Revised" License
1k stars 84 forks source link

Random#rand now working with Bignums #827

Closed merryman closed 7 years ago

merryman commented 10 years ago

Finished Bignum#rand implementation requested in issue #780

alex commented 10 years ago

It looks like there's a few flake8 issues, and an escaped value error, which causes the unskipped tests to fail?

merryman commented 10 years ago

Yeah, just recognized. For the future: is there a way to run these coding style tests locally before I push + commit changes?

alex commented 10 years ago

If you look in tasks/travis.py and copy the flake8 invocation that should do it.

merryman commented 10 years ago

I can't reproduce the failure that is triggered by running mspec on travis. How can this be something platform specific?

alex commented 10 years ago

I'm not really sure. This uses the latest rubyspec always, is your rubyspec out of date maybe?

merryman commented 10 years ago

Yeah, apparently my ruby spec needed an update, but now I'm getting the same errors on the master branch. Seems to be a change within rubyspec that causes the whole interpreter to crash at some point of execution.

alex commented 10 years ago

Grumble. I guess we need to figure out which new test needs to be skipped (or fixed) before we can review this.

On Fri, Nov 8, 2013 at 8:33 PM, Robin Schreiber notifications@github.comwrote:

Yeah, apparently my ruby spec needed an update, but now I'm getting the same errors on the master branch. Seems to be a change within rubyspec that causes the whole interpreter to crash at some point of execution.

— Reply to this email directly or view it on GitHubhttps://github.com/topazproject/topaz/pull/827#issuecomment-28117732 .

"I disapprove of what you say, but I will defend to the death your right to say it." -- Evelyn Beatrice Hall (summarizing Voltaire) "The people's good is the highest law." -- Cicero GPG Key fingerprint: 125F 5C67 DFE9 4084

timfel commented 10 years ago

We shouldn't be using rubyspec master anymore, it dropped support for pre 2.0 Rubies. See https://github.com/rubyspec/rubyspec/issues/259. We need to switch to the 1.x branch instead

alex commented 10 years ago

Ah, nice catch! Can you send a PR to make sure we check out that branch?

On Sat, Nov 9, 2013 at 12:47 AM, Tim Felgentreff notifications@github.comwrote:

We shouldn't be using rubyspec master anymore, it dropped support for pre 2.0 Rubies. See rubyspec/rubyspec#259https://github.com/rubyspec/rubyspec/issues/259. We need to switch to the 1.x branch instead

— Reply to this email directly or view it on GitHubhttps://github.com/topazproject/topaz/pull/827#issuecomment-28122850 .

"I disapprove of what you say, but I will defend to the death your right to say it." -- Evelyn Beatrice Hall (summarizing Voltaire) "The people's good is the highest law." -- Cicero GPG Key fingerprint: 125F 5C67 DFE9 4084