search

topazproject / topaz

A high performance ruby, written in RPython
topazruby.com
BSD 3-Clause "New" or "Revised" License
1k stars 84 forks source link

Float formatting #838

Closed codeZeilen closed 10 years ago

codeZeilen commented 10 years ago

Proposal to fix #779. Float#to_s should create the closest string representation of the float which itself creates the float again. The RPython float to string mode "r" allows this and only needed some polishing to match the formatting of Ruby 1.9.3

timfel commented 10 years ago

Of there is a rubyspec for this, can you make sure it runs? (untagging it should work)

timfel commented 10 years ago

s/Of/If

codeZeilen commented 10 years ago

Sure I'll have a look

codeZeilen commented 10 years ago

Turns out the Float#to_s specs include all the information I was manually assembling before -.-'. Thus my changes don't implement everything yet, so I'm closing the pull request for now and reopen it when I've also implemented the rest of the Float#to_s spec.