search

topclaudy / compoships

Multi-columns relationships for Laravel's Eloquent ORM
MIT License
1.1k stars 130 forks source link

Fix README incorrect param name #124

Closed hms5232 closed 2 years ago

hms5232 commented 2 years ago

I think that the 3rd param of belongsTo is ownerKey not localKey (according to Laravel docs).

If i get it wrong, you can close PR.

If PR is accepted and you don't mind, could you add a hacktoberfest-accepted label to help me with hacktoberfest? Thanks!

topclaudy commented 2 years ago

Thanks @hms5232. I think it's too late for hacktoberfest. Sorry for the delay

hms5232 commented 2 years ago

Thanks @hms5232. I think it's too late for hacktoberfest. Sorry for the delay

Don't worry! That is additional bonus. I'm happy that I can contribute towards repo :)