Closed parallels999 closed 1 year ago
@parallels999 Yes... if the DB/Eloquent layer in Laravel 10.x doesn't introduce breaking changes.
Thanks for answer, great work
There was 1 error:
1) Awobaz\Compoships\Tests\Unit\HasManyTest::test_Compoships_eagerLoading
TypeError: Illuminate\Database\Eloquent\Relations\Relation::whereInEager():
Argument #2 ($key) must be of type string, array given,
called in /home/travis/build/topclaudy/compoships/vendor/illuminate/database/Eloquent/Relations/HasOneOrMany.php
on line 105
/home/travis/build/topclaudy/compoships/vendor/illuminate/database/Eloquent/Relations/Relation.php:398
/home/travis/build/topclaudy/compoships/vendor/illuminate/database/Eloquent/Relations/HasOneOrMany.php:105
/home/travis/build/topclaudy/compoships/vendor/illuminate/database/Eloquent/Builder.php:749
/home/travis/build/topclaudy/compoships/vendor/illuminate/database/Eloquent/Builder.php:727
/home/travis/build/topclaudy/compoships/vendor/illuminate/database/Eloquent/Builder.php:695
/home/travis/build/topclaudy/compoships/tests/Unit/HasManyTest.php:236
--
There was 1 incomplete test:
1) Awobaz\Compoships\Tests\Unit\HasManyTest::broken_Compoships_hasOneOrMany_whereInMethod__missingRelationColumn
This test is broken, because relation columns are required on selections!
/home/travis/build/topclaudy/compoships/tests/Unit/HasManyTest.php:34
is there breaking changes?
@topclaudy is there gonna be Laravel 10.x support?