search

topcoat-data / topcoat-public

TopCoat components, visualizations and themes
MIT License
1 stars 3 forks source link

Fix/tooltip transition #137

Closed gau94rav closed 2 years ago

gau94rav commented 2 years ago

Problem:

  1. When tooltip opens, it sometimes have a broken layout for half a second, until it corrects itself.
  2. Transition of tooltip open and close is very static.

Solution

  1. Prevent tooltip from resetting it's position state on each mouse hover and trigger placement logic AFTER it appears.
  2. Add fade transition using vue's <transition /> tag.

How to test

  1. Switch to this branch inside IDE.
  2. Open executive or issues page, click on pdf download or hover on url copy button.

Expected results

  1. No broken flash when it opens.
  2. Subtle fade animation on open and close.
sareg0 commented 2 years ago

Thanks for leaving the comment about the code change! I wouldn't be opposed to fixing the indentation of this file if you felt like doing that too, but it doesn't have to block you.