search

topcoat-data / topcoat-public

TopCoat components, visualizations and themes
MIT License
1 stars 3 forks source link

Feat/t tabs #235

Closed gau94rav closed 1 year ago

gau94rav commented 1 year ago

Multiple tabs fixes

  1. Moving TTabs.vue file to visualizations folder, was accidentally stored to library, because it stores the tab value as a filter value in URL, which is important to handle active tab.

  2. Force tab contents to reload using key, required for plotly.

sareg0 commented 1 year ago

  • Moving TTabs.vue file to visualizations folder, was accidentally stored to library, because it stores the tab value as a filter value in URL, which is important to handle active tab.

Does this mean the filter value is not going to be stored in the URL anymore?

Please, in future, leave directions about how to test and/or a demonstration of the problem being fixed (screenshots or recordings) etc.

gau94rav commented 1 year ago
  • Moving TTabs.vue file to visualizations folder, was accidentally stored to library, because it stores the tab value as a filter value in URL, which is important to handle active tab.

Does this mean the filter value is not going to be stored in the URL anymore?

Please, in future, leave directions about how to test and/or a demonstration of the problem being fixed (screenshots, recordings) etc.

@sareg0 It will be stored in URL, that's how every visualization works, I accidentally left this file inside library last time, it was meant for visualization folder instead.

If you want to test, this is the syntax.

<t-tabs
    t-layer="any_empty_sql_file"
    t-filter:tab="url_param_name"
    :tabs="[{label: 'Tabone', slot: 'tabone'}]"
>
    <div slot="tabone">Tab one section</div>
</t-tabs>