fix: only add grid columns if collapsable has rows

[benbarnett]

What this does

Following on from #248, there was another edge case where if the table initially loads data, and then some combination of applied filters means that the table returns no results -- then the template columns were required again.

I've tested this with:

• standard tables that have initial data (and then applied a filter to produce an empty table again)
  • this is the one that required this fix
• standard tables that have no initial data
  • rendered as expected and as before
• collapsable tables that have initial data (and then applied a filter to produce an empty table again)
  • rendered as expected and as before
• collapsable tables that have no initial data
  • rendered as expected and as before

Screenshots for the states that had the layout issue shown below;

Before (in main):

With this fix:

Notes for the reviewer

Instructions on how to run this locally, background context, what to review, best to review commit-by-commit?, questions…

Missed anything?

• [ ] Performance (customer with 200k users, customer with 1k orgs etc). Review the Performance documentation
• [ ] Security aspects considered? Unhappy paths?
• [ ] Have you accounted for accessibility?
• [ ] Commit messages and bodies explain what and why?

More information

• Slack thread
• Jira ticket

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots, including URL if applicable, for any front end change. GIFs are most welcome!

[egcastro]

Did you have a chance to test those cases on the PDF version of other reports? I know Insights it's not using the PDF feature but to see if these changes affect (for good or bad) the current PDF tables.

[benbarnett]

@egcastro I checked the Issues Detail and Vuln detail reports, exported both to PDF (standard & collapsable accordingly), and as far as I can tell everything aligns with prod (with data and without data)