Closed sareg0 closed 1 year ago
Table headers were attempting to sort the table (and failing), even when the sort option was not set. This PR fixes that by making rendering a button/attaching a click handler conditional.
To test this component:
config.yml
modules: - git: https://github.com/topcoat-data/topcoat-public.git revision: fix/table-sort-condition
Build and Sync Modules
What this does
Table headers were attempting to sort the table (and failing), even when the sort option was not set. This PR fixes that by making rendering a button/attaching a click handler conditional.
Notes for the reviewer
To test this component:
config.yml
file and replace the branch for topcoat-public with this branch name:Build and Sync Modules
(the cloud icon) in the left hand menuMore information
Screenshots / GIFs
Before
Sortable Column (Analytics Report, Exposure Tab)
Column without sort (Analytics Report, Manage Tab)
After
Sortable Column (Analytics Report, Exposure Tab)
Column without sort (Analytics Report, Manage Tab)