topcoder-platform / admin-app

Customer support application
7 stars 25 forks source link

Admin Tool doesn't update SSO user's email in all places #107

Open JayaDhaka opened 6 years ago

JayaDhaka commented 6 years ago

Issue description: Updating a SSO user doesn't update email at all places.

Steps to Reproduce

  1. Create a SSO user with an email address (a@a.com)
  2. Login with the user
  3. Change user email to b@b.com
  4. User is able to login using the old email address only (cannot login using the new email address)

Possible Fix: Updating the user primary email via Admin Tool, should also update the sso_user_login email address in the database.

ajefts commented 6 years ago

@huangqun Can you work on this one next? There are some inconsistencies when we update user sso records using the admin tool so we need to make sure we create/update the complete set of data. For example, the email address in user_sso_login is not getting set when we use the admin tool to set SSO info for an existing user.

huangqun commented 6 years ago

@ajefts just to be sure, it means when we change this the admin app should automatically update the sso_user_login email address too?

http://take.ms/xHHbp

Do we need to have an extra field to update the email here as well? http://take.ms/oIjeR

If we need to update the Edit SSO User popup too, then we need to fix the api issue I described here: https://github.com/topcoder-platform/admin-app/pull/99

ajefts commented 6 years ago
  1. it means when we change this the admin app should automatically update the sso_user_login email address too http://take.ms/xHHbp -- YES

  2. Do we need to have an extra field to update the email here as well? http://take.ms/oIjeR -- YES

In reality, the 2 emails above will always match.

I'll check the other issue and comment there...

huangqun commented 6 years ago

@ajefts based on our discussion in https://github.com/topcoder-platform/admin-app/pull/99, I guess we need to update the email in all places (the primary email, and email in all sso identities) whenever we change any of the primary email / sso emails?

ajefts commented 6 years ago

Based on what we learned about our support for multi-sso profiles per user, I think we need to adjust this now.

Let's not auto update the sso email address field when we change the users primary email. Instead, let's just make sure we have the ability to edit the SSO email for the user here:

image

Also, we don't need to do this right way since we don't have the use case in reality yet, but this screen to manage the sso info for a user will need to support multiple sso identities...

huangqun commented 6 years ago

This is done.