topcoder-platform / community-app

React webapp for serving Topcoder Community
125 stars 212 forks source link

Make the stats history data to support groupIds query params and use new API to render the stats history UI #4137

Open LieutenantRoger opened 4 years ago

LieutenantRoger commented 4 years ago
  1. Community-app - Allowing seeing stats history for topgear / other communities. Was disable during last release.

  2. Community-app - Change Stats History web service call to fetch data by passing groupsId, as we did for member stats, and use the retrieved stats from new API to render the UI.

Please make sure both public history page and topgear history page are working correctly.

LieutenantRoger commented 4 years ago

Also please only test topgear group for now.

LieutenantRoger commented 4 years ago

FYI @urwithat @Oanh-and-only-Oanh

SathyaJayabal commented 4 years ago

@LieutenantRoger , was able to view both the public and private stats history page for the user standlove. There are a few inconsistencies in the data like the below

  1. Even though the ratings are different for the design, architecture and assembly tracks(for public and private history), the challenge details are all the same

    Screenshot 2020-03-30 at 1 27 46 PM
  2. The rating history graph for topgear for the design track does not match the rating

    Screenshot 2020-03-30 at 1 23 45 PM
  3. Even though the. user has the same data. for SRMs in both the public and private history pages, the rating history graph is not displayed for topgear.

    Screenshot 2020-03-30 at 1 30 37 PM Screenshot 2020-03-30 at 1 30 43 PM
  4. Rating distribution graph for private history of assembly track does not show the users rating.

Screenshot 2020-03-30 at 1 32 37 PM
LieutenantRoger commented 4 years ago

Hi @SathyaJayabal

As have discussed, this is the expected behavior due to the testing data preparation.

Btw, I have re-deployed the feature using topcoder-react-lib#v1000.14.0 to dev env for QA.

SathyaJayabal commented 4 years ago

@LieutenantRoger for the. topcoder stats history page(public) there should not abe any group id passed right?

SathyaJayabal commented 4 years ago

@LieutenantRoger for the call to stats history page for topgear, there are. two group ids passed. Topgear group is "20000000", why is the other id passed ?

Screenshot 2020-03-30 at 5 04 38 PM
LieutenantRoger commented 4 years ago

It's expected as well, please refer the stats call for reference when you are checking history call.

LieutenantRoger commented 4 years ago

@LieutenantRoger for the. topcoder stats history page(public) there should not abe any group id passed right?

Correct, when there is no group id provided in the request, the history data with groupId=10 will be returned by default.

SathyaJayabal commented 4 years ago

@LieutenantRoger , I am. passing this one as per clarifications above. The public and topgear stats history pages are displayed for the user standlove. The group id is passed in the history call.

SathyaJayabal commented 4 years ago

verified on dev(develop branch)

Screenshot 2020-03-31 at 2 20 32 PM Screenshot 2020-03-31 at 2 20 43 PM Screenshot 2020-03-31 at 2 21 19 PM Screenshot 2020-03-31 at 2 21 42 PM
LieutenantRoger commented 4 years ago

Thanks @SathyaJayabal

LieutenantRoger commented 4 years ago

@lakshmiathreya please close if the ticket is resolved. It's been long time now.

SathyaJayabal commented 4 years ago

@LieutenantRoger ,the stats data is still not visible for top gear users in production. @lakshmiathreya can u verify this please. Clicking on any user from the topgear leaderboard should show the profile page with stats.

SathyaJayabal commented 4 years ago

@LieutenantRoger the below user must have stats data in topgear but the stats are not showing up

Screenshot 2020-04-14 at 10 23 24 PM
LieutenantRoger commented 4 years ago

@SathyaJayabal got it. I just remembered the production data under topgear are still under processing, I think this is the reason that no data is returned, we can keep the ticket as open now, thanks.

sushilshinde commented 4 years ago

@LieutenantRoger need pr for this

SathyaJayabal commented 4 years ago

marking this as hold until backend data is ready for topgear stats history on prod cc @LieutenantRoger @Oanh-and-only-Oanh

lakshmiathreya commented 3 years ago

@Oanh-and-only-Oanh I am reopening this - it appears like Code was fixed but backend data was not available. Will leave this open until we see Stats data fully. cc @urwithat @SathyaJayabal