Should update the tests for the API changes done for design challenges. Instead, you just remove
isSubmitting: false,
submitDone: false,
submitErrorMsg: '',
from the tests to make them pass
Spec states 'For any data related to the specific page (i.e. mostly UI state of a specific page, that is of
no importance for different page) please start a new segment in Redux state,
state.page.challenge.submission, i.e. the plan is to keep this segment mimicing the actual page hierarchy inside the app, and to keep here all page-scope data.'
Should use same name as in spec instead of state.page.challengeDetails.submission
Resolved Issues
Highlight of the file drop box, when the file is dragged and dropped, is active only on border.
Header comments are missing progress param:
/**
* Payload creator for the action that actually performs submission operation.
* @param {String} tokenV3
* @param {String} tokenV2
* @param {String} submissionId
* @param {Object} body Data to submit.
* @param {String} track Competition track of the challenge where we submit.
* @return Promise
*/
function submitDone(tokenV3, tokenV2, submissionId, body, track, progress) {
return getChallengesService(tokenV3, tokenV2)
Works fine for me in a6f3548f0f84efb6aafae173af6e1a89116695ad (tested both as TonyJ, and dan_developer)
~~Dragging a file onto zip file area here leads to 403 error - https://cl.ly/0b013I1h042c
Since it uses FileStack, you should disable file drag and drop on these boxes~~
Closing, as the main issues have been solved, and two other notes are not that important, and can be resolved later, when we do something with related code for some good reason.
Should update the tests for the API changes done for design challenges. Instead, you just remove isSubmitting: false, submitDone: false, submitErrorMsg: '',
from the tests to make them pass
Spec states 'For any data related to the specific page (i.e. mostly UI state of a specific page, that is of no importance for different page) please start a new segment in Redux state, state.page.challenge.submission, i.e. the plan is to keep this segment mimicing the actual page hierarchy inside the app, and to keep here all page-scope data.'
Should use same name as in spec instead of state.page.challengeDetails.submission
Resolved Issues
Highlight of the file drop box, when the file is dragged and dropped, is active only on border.Header comments are missing progress param: