search

topcoder-platform / community-app

React webapp for serving Topcoder Community
125 stars 214 forks source link

UN-129 - improve universal-nav ssr placeholder #6828

Closed vas3a closed 1 year ago

vas3a commented 1 year ago

https://topcoder.atlassian.net/browse/UN-129

Improves the universal-nav's placeholder: show the correct number of navigation bars based on current url & type of nav

image image

jmgasper commented 1 year ago

@vas3a - Can you change this to point to the universal_nav branch please instead of develop?

vas3a commented 1 year ago

@jmgasper This has been started from develop. Do you want me to rebase the changes on universal_nav and open a new PR?

jmgasper commented 1 year ago

@vas3a - Saw the update, thanks! The problem with develop is that it's actually deployed to staging, which uses the production uninav. Not sure why, as that's different than literally every other app we deploy, but I've learned not to question that sort of thing :)