topcoder-platform / community-app

React webapp for serving Topcoder Community
125 stars 214 forks source link

Show security reminder to members before downloading project data #6880

Closed jmgasper closed 1 year ago

jmgasper commented 1 year ago

REF: https://topcoder.atlassian.net/browse/PROD-4255

Description

As a member, when I attempt to download data from a challenge/work item, I should be reminded to keep project data private and delete it at project completion, to reduce the risk of accidental data leakage.

Implementation

For challenges where an NDA is required, we will show a popup when the "Register" button is clicked.

We will show the text below, along with a checkbox that says "I agree" and then another button "Register" that will complete the registration. Note that the "Register" button in the popup will only be enabled once I agree is checked

Text

IMPORTANT REMINDER: In accordance with the Terms & Conditions and Code of Conduct you agree:

suppermancool commented 1 year ago

@jmgasper done in community-app-issue-6880.patch (the patch against commit 723a52a5a485d1e775ee7f73b392b32fc041a58b in develop branch)

jmgasper commented 1 year ago

@suppermancool - I don't think this is quite right. We want to show this for every member registering for every challenge with an NDA, regardless of whether or not they've already agreed to the terms.

Here's a test challenge in dev: https://www.topcoder-dev.com/challenges/9a76f0c8-bf91-40d3-b871-72423df39933?tab=details

suppermancool commented 1 year ago

@jmgasper pls revert my previous patch file, thanks! Done in community-app-issue-6880.patch (the patch against commit 723a52a5a485d1e775ee7f73b392b32fc041a58b in develop branch)

jmgasper commented 1 year ago

@suppermancool - Looks good, thanks. Can we add an "X" in the upper right to cancel out of the popup please?

SCR-20230524-kngz
suppermancool commented 1 year ago

@jmgasper pls revert my previous patch file, thanks! Done in community-app-issue-6880.patch (the patch against commit 723a52a5a485d1e775ee7f73b392b32fc041a58b in develop branch)