topcoder-platform / community-app

React webapp for serving Topcoder Community
125 stars 214 forks source link

Security reminder is shown in challenges which do not have NDA required option checked in WM #6882

Closed jmgasper closed 1 year ago

jmgasper commented 1 year ago

Register to challenge https://staging-community-app.topcoder.com/challenges/b1e6defe-d50a-4f11-a07b-6780e67e934a (which does not need NDA)

Expected: only NDA required challenges should show the security reminder

Actual: challenges without NDA also show security reminder

@suppermancool - I think the problem here is that we're checking for any terms on a challenge, but we need to check specifically for the terms ID that matches the NDA requirement.

I think the term ID in prod is:

https://api.topcoder.com/v5/terms/05342dcb-3405-445e-95b2-8ea2a3834b0d

https://github.com/topcoder-platform/community-app/assets/21790/157d2f3c-fed5-4ab4-8c59-5ce3680ac99b