search

topcoder-platform / mfe-customer-work

3 stars 10 forks source link

PROD-2122 Redirect to work dashboard when user is log in -> Dev #468

Closed hentrymartin closed 2 years ago

hentrymartin commented 2 years ago

What's this PR is about?

I want to discuss in the PR whether we need to fix this url.

Context:

In login-prompt component, the fallback url is hardcoded to "/self-service/branding" which is the old branding url.

There are two scenario's here,

  1. When user is log in
  2. When user is not log in

Scenario 1(When user is log in):

  1. Going to this url(https://platform.topcoder-dev.com/self-service/login-prompt) redirects to the old branding page(https://platform.topcoder-dev.com/self-service/branding)

Scenario 2(When user is not log in):

  1. Going to login prompt url(https://platform.topcoder-dev.com/self-service/login-prompt) does not redirect but displays the login prompt page(which is correct I believe).

@brooketopcoder Personally I think the scenario 1 is not valid since the user won't be going to login-prompt if they are already log in. Do I have to fix the url here? Am I missing something else because of my restricted knowledge in existing functionality?

Thanks!