[$45] Able to submit even without registering

[LieutenantRoger]

Summary: Able to upload Submission for a challenge even without registering

Steps to Reproduce:

1. Navigate to Some Challenge and Register.
2. Right Click on Submit and Open in New Tab
3. Now go back to the Challenge Details page and Unregister
4. Now go to the other tab where Submission page is open
5. Check if you are able to make the submission

Actual Result: User is able to make submission even without registering

Expected Result: User should not be let to make the submission since user is unregistered from the Challenge

Environment Details: Devices(s): PC Operating System: Windows 10 Browser and Version: Chrome: 94.0.4606.81

[LieutenantRoger]

Challenge https://www.topcoder.com/challenges/6a184130-5370-4cea-98ed-96829b22c969 has been created for this ticket.

This is an automated message for lieutenantroger via Topcoder X

[fikzzzy]

@bug-bash-helper assign

[bug-bash-helper[bot]]

@fikzzzy ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

[bug-bash-hunt-helper[bot]]

@fikzzzy ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

[fikzzzy]

@bug-bash-helper unassign

[bug-bash-helper[bot]]

@fikzzzy ✅ you have been unassigned from this issue.

Now you may pick up another issue which is open for pickup if you like to.

[bug-bash-hunt-helper[bot]]

@fikzzzy ✅ you have been unassigned from this issue.

Now you may pick up another issue which is open for pickup if you like to.

[ben-mathu]

@bug-bash-helper assign

[bug-bash-helper[bot]]

@ben-mathu ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

[bug-bash-hunt-helper[bot]]

@ben-mathu ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

[dprincecoder]

@bug-bash-helper assign

[bug-bash-helper[bot]]

@dprincecoder 🛑 this issue is not open for pick up.

You may only pickup issues which are included in this Bug Bash and open for pick up. Such issues have open status and have labels CF and Open for Pickup.

[bug-bash-hunt-helper[bot]]

@dprincecoder 🛑 this issue is not open for pick up.

You may only pickup issues which are included in this Bug Bash and open for pick up. Such issues have open status and have labels CF and Open for Pickup.

[ben-mathu]

I cannot login using localhost:8080 I have tried to use the local.topcoder-dev.com, but I cannot see the top bar, navbar is hidden.Could someone help with this?

[LieutenantRoger]

@ben-mathu Please read the challenge specific firstly and carefully regarding how to deploy the application locally.

You may pickup open ticket once you have resolved the local deployment issue. :)

[LieutenantRoger]

I will unassign you for now so other members without deployment issue can continue to fix this issue.

[shivam-51]

@bug-bash-helper assign

[bug-bash-hunt-helper[bot]]

@shivam-51 🛑 you have some issues assigned which are not completed yet, see https://github.com/topcoder-platform/micro-frontends-challenges-app/issues/101, https://github.com/topcoder-platform/micro-frontends-challenges-app/issues/96, https://github.com/topcoder-platform/micro-frontends-challenges-app/issues/95.

As per our Bug Bash rules you may work only at one issue at a time. Please, complete other issues first or unassign yourself before picking up a new issue.

[shivam-51]

@bug-bash-helper assign

[bug-bash-hunt-helper[bot]]

@shivam-51 🛑 you have some issues assigned which are not completed yet, see https://github.com/topcoder-platform/micro-frontends-challenges-app/issues/96, https://github.com/topcoder-platform/micro-frontends-challenges-app/issues/95.

As per our Bug Bash rules you may work only at one issue at a time. Please, complete other issues first or unassign yourself before picking up a new issue.

[shivam-51]

@bug-bash-helper assign

[bug-bash-hunt-helper[bot]]

@shivam-51 ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

[LieutenantRoger]

Challenge https://www.topcoder.com/challenges/6a184130-5370-4cea-98ed-96829b22c969 has been assigned to shivam51.

This is an automated message for lieutenantroger via Topcoder X

[shivam-51]

@bug-bash-helper unassign

[bug-bash-hunt-helper[bot]]

@shivam-51 ✅ you have been unassigned from this issue.

Now you may pick up another issue which is open for pickup if you like to.

[LieutenantRoger]

Challenge https://www.topcoder.com/challenges/6a184130-5370-4cea-98ed-96829b22c969 shivam51 has been unassigned.

This is an automated message for lieutenantroger via Topcoder X

[flaming-cl]

@bug-bash-helper assign

[bug-bash-hunt-helper[bot]]

@flaming-cl ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

[flaming-cl]

@bug-bash-helper pull request is ready for review

[bug-bash-hunt-helper[bot]]

@flaming-cl ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

[LieutenantRoger]

1. It's not a good idea to retrieve the challenge detail info one more time only to verify the member is regsitered in a challenge.

https://api.topcoder-dev.com/v5/resources?challengeId={challengeId}

I think you should relay on this API endpoint, which can get the resources of a challenge directly to see if the member has unregistered the challenge, so we avoid to reload challenge detail and other API data which we don't need.

[flaming-cl]

Hi, thanks so much for your feedback. The pull request is updated with the suggestions you've made. @bug-bash-helper pr is ready for review

[bug-bash-hunt-helper[bot]]

@flaming-cl ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

[LieutenantRoger]

Hmmm I don't think the new PR is correct.

You called the getChallenge this time right ? I believe it's a different endpoint with the resource API. So we should only need to call resource API to verify whether a member has registered a challenge or not.

[flaming-cl]

@LieutenantRoger Sorry that I mistakenly thought "resources?challengeId={challengeId}" is for fetching the challenge resource. The API will just retrieve the registrants data. Thanks for explaining.

[flaming-cl]

@bug-bash-helper pr is ready for review

[bug-bash-hunt-helper[bot]]

@flaming-cl ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

[codejamtc]

Fixed :ok:

https://user-images.githubusercontent.com/42398485/143733984-0077e599-fc84-459d-aac9-5a9222b4f601.mp4

[codejamtc]

Verified in Prod :ok:

https://user-images.githubusercontent.com/42398485/143866035-7248ff6a-dc10-4084-b968-7940e91ea99c.mp4