topcoder-platform / micro-frontends-challenges-app

0 stars 12 forks source link

When we click on "Closed Challenges" and Choose Date range as "Past Month", it still shows Challenges out of that range #119

Closed LieutenantRoger closed 2 years ago

LieutenantRoger commented 3 years ago

Summary:

Steps to Reproduce:

  1. Go to https://platform.topcoder.com/earn/find/challenges
  2. Click on All Active Challenges
  3. Then click on "Closed Challenges"
  4. Choose Date range as Past Month (29th Sep, 2021 - 30th Oct, 2021)
  5. Challenge list still shows challenges Ending on 31st Oct, 2021 which are out of range

Actual Result:

*When we click on "Closed Challenges" and Choose Date range as "Past Month", it still shows Challenges out of that range

Expected Result:

Environment Details:

Devices(s):

Operating System and version:

Browser and version:

Screen recording or Screen snapshot:
Issue_6

LieutenantRoger commented 3 years ago

Challenge https://www.topcoder.com/challenges/d39be9c3-794a-41f9-8209-a1cd87acf295 has been created for this ticket.

This is an automated message for lieutenantroger via Topcoder X

shivam-51 commented 3 years ago

@bug-bash-helper assign

bug-bash-helper[bot] commented 3 years ago

@shivam-51 ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review
bug-bash-hunt-helper[bot] commented 3 years ago

@shivam-51 ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review
LieutenantRoger commented 3 years ago

Challenge https://www.topcoder.com/challenges/d39be9c3-794a-41f9-8209-a1cd87acf295 has been assigned to shivam51.

This is an automated message for lieutenantroger via Topcoder X

shivam-51 commented 3 years ago

@bug-bash-helper unassign

bug-bash-helper[bot] commented 3 years ago

@shivam-51 ✅ you have been unassigned from this issue.

Now you may pick up another issue which is open for pickup if you like to.

bug-bash-hunt-helper[bot] commented 3 years ago

@shivam-51 ✅ you have been unassigned from this issue.

Now you may pick up another issue which is open for pickup if you like to.

LieutenantRoger commented 3 years ago

Challenge https://www.topcoder.com/challenges/d39be9c3-794a-41f9-8209-a1cd87acf295 shivam51 has been unassigned.

This is an automated message for lieutenantroger via Topcoder X

LieutenantRoger commented 3 years ago

Challenge https://www.topcoder.com/challenges/d39be9c3-794a-41f9-8209-a1cd87acf295 has been assigned to yoution.

This is an automated message for lieutenantroger via Topcoder X

LieutenantRoger commented 3 years ago

Challenge https://www.topcoder.com/challenges/d39be9c3-794a-41f9-8209-a1cd87acf295 yoution has been unassigned.

This is an automated message for lieutenantroger via Topcoder X

LieutenantRoger commented 3 years ago

Challenge https://www.topcoder.com/challenges/d39be9c3-794a-41f9-8209-a1cd87acf295 has been assigned to yoution.

This is an automated message for lieutenantroger via Topcoder X

LieutenantRoger commented 3 years ago

Challenge https://www.topcoder.com/challenges/d39be9c3-794a-41f9-8209-a1cd87acf295 yoution has been unassigned.

This is an automated message for lieutenantroger via Topcoder X

nqviet commented 3 years ago

@bug-bash-helper assign

bug-bash-helper[bot] commented 3 years ago

@nqviet ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review
bug-bash-hunt-helper[bot] commented 3 years ago

@nqviet ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review
LieutenantRoger commented 3 years ago

Challenge https://www.topcoder.com/challenges/d39be9c3-794a-41f9-8209-a1cd87acf295 has been assigned to nqv2018.

This is an automated message for lieutenantroger via Topcoder X

nqviet commented 3 years ago

@LieutenantRoger

The current filter is choosing the challenges which started before 30-Oct and ended after 29-Sep. In other words, the filter will list all challenges that their durations intersect with the filter [startDate, endDate].

ex: Untitled

Could you please elaborate?

nqviet commented 3 years ago

@bug-bash-helper unassign

bug-bash-helper[bot] commented 3 years ago

@nqviet ✅ you have been unassigned from this issue.

Now you may pick up another issue which is open for pickup if you like to.

bug-bash-hunt-helper[bot] commented 3 years ago

@nqviet ✅ you have been unassigned from this issue.

Now you may pick up another issue which is open for pickup if you like to.

LieutenantRoger commented 3 years ago

Challenge https://www.topcoder.com/challenges/d39be9c3-794a-41f9-8209-a1cd87acf295 nqv2018 has been unassigned.

This is an automated message for lieutenantroger via Topcoder X

LieutenantRoger commented 3 years ago

Challenge https://www.topcoder.com/challenges/d39be9c3-794a-41f9-8209-a1cd87acf295 has been assigned to yoution.

This is an automated message for lieutenantroger via Topcoder X

LieutenantRoger commented 3 years ago

Challenge https://www.topcoder.com/challenges/d39be9c3-794a-41f9-8209-a1cd87acf295 yoution has been unassigned.

This is an automated message for lieutenantroger via Topcoder X

LieutenantRoger commented 3 years ago

@LieutenantRoger

The current filter is choosing the challenges which started before 30-Oct and ended after 29-Sep. In other words, the filter will list all challenges that their durations intersect with the filter [startDate, endDate].

ex: Untitled

Could you please elaborate?

Oh, I missed this ticket, @nqviet Thanks for this snapshot, I will need to get it clarified

flaming-cl commented 3 years ago

@LieutenantRoger The problem is not only showing challenges out of range, but also not showing challenges within range.

Take this challenge as an example: Ended Sep 24

First, we pick up a time period ranging from Sep 13, 2021 to Sep 20, 2021. As we have known, it shows challenges out of the date range. CHALLENGES However, if we pick up a time period ranging from Sep 15, 2021 to Nov 18, 2021, the challenges Design-Task-Automation ended in Sep 24, 2021 disappear. CHALLENGES

Why this happens?

It may be because there are two end dates of each challenge:

  1. After querying, the backend API will return an end date (in the example, it is endDate: "2021-09-14T13:42:45.000Z"): created 2021-09-13T134233 4712

  2. In the challenge item component, there is an end date calculated through challenge.phases (in the example, it is scheduledEndDate:“2021-09-24T13:42:45.000Z”) Ended Sep 24

The front-end side displays challenge items based on the second end date (Sep 24).

However, it seems that the back-end side filters challenges based on the first date (Sep 14).

Therefore, when filtering challenges through the time period (Sep 13, 2021 - Sep 20, 2021), the challenge Design-Task-Automation challenge (Ended: Sep 24) is shown in the search result.

With the same reason, the challenge is not shown when picking up a date started from Sep 15, 2021.

If what I guess is correct, it may be better to solve this problem from the back-end side: the front-end side can help to filter out of range challenge items, but it may not be very effective to show the disappeared items, filtered out by the back-end API.

Screen Shot 2021-11-18 at 10 58 35 PM

nqviet commented 3 years ago

@bug-bash-helper assign

bug-bash-helper[bot] commented 3 years ago

@nqviet 🛑 you have some issues assigned which are not completed yet, see https://github.com/topcoder-platform/micro-frontends-challenges-app/issues/145, https://github.com/topcoder-platform/micro-frontends-challenges-app/issues/143, https://github.com/topcoder-platform/micro-frontends-challenges-app/issues/132, https://github.com/topcoder-platform/micro-frontends-challenges-app/issues/116, https://github.com/topcoder-platform/micro-frontends-challenges-app/issues/97, https://github.com/topcoder-platform/micro-frontends-challenges-app/issues/75.

As per our Bug Bash rules you may work only at one issue at a time. Please, complete other issues first or unassign yourself before picking up a new issue.

bug-bash-hunt-helper[bot] commented 3 years ago

@nqviet 🛑 you have some issues assigned which are not completed yet, see https://github.com/topcoder-platform/micro-frontends-challenges-app/issues/145, https://github.com/topcoder-platform/micro-frontends-challenges-app/issues/143, https://github.com/topcoder-platform/micro-frontends-challenges-app/issues/132, https://github.com/topcoder-platform/micro-frontends-challenges-app/issues/116, https://github.com/topcoder-platform/micro-frontends-challenges-app/issues/97, https://github.com/topcoder-platform/micro-frontends-challenges-app/issues/75.

As per our Bug Bash rules you may work only at one issue at a time. Please, complete other issues first or unassign yourself before picking up a new issue.

flaming-cl commented 3 years ago

@bug-bash-helper assign

bug-bash-helper[bot] commented 3 years ago

@flaming-cl ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review
bug-bash-hunt-helper[bot] commented 3 years ago

@flaming-cl ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review
nqviet commented 3 years ago

@LieutenantRoger @flaming-cl For the above challenge, its end-date seems to be 14 Sep, but the frontend is showing 24 Sep instead?

Untitled

Untitled2

flaming-cl commented 3 years ago

@nqviet Hi, for the exact end date, the date Sep 24 sounds better (if the challenge starts registration at Sep 23).

But I guess we still need some clarification from @LieutenantRoger. Many thanks!

LieutenantRoger commented 3 years ago

Ops, I seems missed the discussion in this ticket. I will need some time to check the data.

flaming-cl commented 3 years ago

@bug-bash-helper unassign

bug-bash-hunt-helper[bot] commented 3 years ago

@flaming-cl ✅ you have been unassigned from this issue.

Now you may pick up another issue which is open for pickup if you like to.