topcoder-platform / micro-frontends-challenges-app

0 stars 12 forks source link

[$10] URL issue when pressing browser back button #258

Closed LieutenantRoger closed 2 years ago

LieutenantRoger commented 2 years ago

Summary:

Steps to Reproduce:

  1. Go to https://platform.topcoder.com/earn/find/challenges
  2. Click on any challenges
  3. Click any of its labels
  4. On the challenges page, click the browser back button
  5. Observe the page and the URL

Actual Result:

Expected Result:

Environment Details:

Devices(s):

Operating System and version:

Browser and version:

Screen recording or Screen snapshot:
back_error

LieutenantRoger commented 2 years ago

Challenge https://www.topcoder.com/challenges/d3003289-8c8c-4a7b-8044-7007d1680634 has been created for this ticket.

This is an automated message for lieutenantroger via Topcoder X

pauline7 commented 2 years ago

@bug-bash-helper assign

bug-bash-hunt-helper[bot] commented 2 years ago

@pauline7 ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review
pauline7 commented 2 years ago

@bug-bash-helper unassign

bug-bash-hunt-helper[bot] commented 2 years ago

@pauline7 ✅ you have been unassigned from this issue.

Now you may pick up another issue which is open for pickup if you like to.

nqviet commented 2 years ago

@bug-bash-helper assign

bug-bash-hunt-helper[bot] commented 2 years ago

@nqviet ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review
LieutenantRoger commented 2 years ago

Challenge https://www.topcoder.com/challenges/d3003289-8c8c-4a7b-8044-7007d1680634 has been assigned to nqv2018.

This is an automated message for lieutenantroger via Topcoder X

nqviet commented 2 years ago

@bug-bash-helper https://github.com/topcoder-platform/micro-frontends-challenges-app/pull/279 is ready for review

bug-bash-hunt-helper[bot] commented 2 years ago

@nqviet ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

nqviet commented 2 years ago

@LieutenantRoger I also included the fixes for responsive https://github.com/topcoder-platform/micro-frontends-challenges-app/pull/280

LieutenantRoger commented 2 years ago

@nqviet For the URL issue, could you take a look the video ? It seems won't go to the detail page per my testing when click the back in the browser.

https://user-images.githubusercontent.com/2875203/144247725-f161b1a7-f06d-49cb-a6ae-e277715f5121.mp4

LieutenantRoger commented 2 years ago

@LieutenantRoger I also included the fixes for responsive #280

Thanks for the responsive fix, let me take a look

nqviet commented 2 years ago

@LieutenantRoger Could you please try to re-run npm run dev on the challenge-apps repo? I tried but could not reproduce it.

https://user-images.githubusercontent.com/36178659/144251271-eccc3a3b-c54a-4226-bf98-8d7c05095903.mp4

.

LieutenantRoger commented 2 years ago

Thanks @nqviet for the video, it seems working fine under https mode. I think then this solution is acceptable. Our Dev and Prod envrionments are all using https mode.

Thanks

nqviet commented 2 years ago

@bug-bash-helper unassign

bug-bash-hunt-helper[bot] commented 2 years ago

@nqviet ✅ you have been unassigned from this issue.

Now you may pick up another issue which is open for pickup if you like to.

LieutenantRoger commented 2 years ago

Challenge https://www.topcoder.com/challenges/d3003289-8c8c-4a7b-8044-7007d1680634 nqv2018 has been unassigned.

This is an automated message for lieutenantroger via Topcoder X

codejamtc commented 2 years ago

@LieutenantRoger Not working for me on Dev

https://user-images.githubusercontent.com/42398485/144344194-8c2dfede-9faa-495a-b4e2-a3d5cf89d5e2.mp4

https://user-images.githubusercontent.com/42398485/144344201-d4c26266-147c-4979-996c-c030bbeecfb9.mp4

codejamtc commented 2 years ago

Fixed :ok:

https://user-images.githubusercontent.com/42398485/144352535-a76786a6-645f-4a6b-a864-8aa952f3a246.mp4

LieutenantRoger commented 2 years ago

Challenge https://www.topcoder.com/challenges/d3003289-8c8c-4a7b-8044-7007d1680634 nqv2018 has been unassigned.

This is an automated message for lieutenantroger via Topcoder X

LieutenantRoger commented 2 years ago

nqv2018 has been unassigned because this ticket doesn't have the tcx_OpenForPickup label.

This is an automated message for lieutenantroger via Topcoder X

LieutenantRoger commented 2 years ago

Challenge https://www.topcoder.com/challenges/d3003289-8c8c-4a7b-8044-7007d1680634 has been assigned to nqv2018.

This is an automated message for lieutenantroger via Topcoder X

codejamtc commented 2 years ago

Fixed in Prod :ok:

https://user-images.githubusercontent.com/42398485/144967369-acd54fa9-3e64-477e-b569-344fc07ade09.mp4

LieutenantRoger commented 2 years ago

Payment task has been updated: https://www.topcoder.com/challenges/d3003289-8c8c-4a7b-8044-7007d1680634 Payments Complete Winner: nqv2018 Copilot: lieutenantroger Challenge d3003289-8c8c-4a7b-8044-7007d1680634 has been paid and closed.

This is an automated message for lieutenantroger via Topcoder X