search

topcoder-platform / micro-frontends-onboarding-app

0 stars 8 forks source link

Contact Info : Timezone #10

Closed SathyaJayabal closed 2 years ago

SathyaJayabal commented 2 years ago

The list of timezones used in the Onboarding app and the connect app must be the same as they read and write to the same trait. Also it will be good to have the time zone list sorted alphabetically like in connect. ref: https://github.com/topcoder-platform/micro-frontends-onboarding-app/blob/develop/src/constants/timezones.json

Screenshot 2021-11-02 at 1 26 12 PM Screenshot 2021-11-02 at 1 25 56 PM
vikasrohit commented 2 years ago

I agree. @rakibansary you can use component from https://github.com/appirio-tech/react-components/blob/feature/connectv2/components/Formsy/TimezoneInput.jsx or copy its list for the time being, if integrating with react-components library causes any issue. https://github.com/appirio-tech/connect-app/blob/dev/package.json#L88 is the way we are using this component library in connect-app.

SathyaJayabal commented 2 years ago

@rakibansary , the timezones are still not sorted alphabetically. I dont thing the fix is merged/deployed yet

Screenshot 2021-11-03 at 8 34 44 PM
rakibansary commented 2 years ago

Hey @SathyaJayabal, this has now been deployed.

SathyaJayabal commented 2 years ago

@rakibansary , the list is fixed. when a user clicks on the dropdown, the current selection must be highlighted.

Screenshot 2021-11-04 at 8 57 31 AM
rakibansary commented 2 years ago

Ready for QA

image