search

topcoder-platform / micro-frontends-onboarding-app

0 stars 7 forks source link

Should "Home" be disabled inside the Onboarding flow #82

Closed rakibansary closed 3 years ago

rakibansary commented 3 years ago

When in the onboarding flow we hide

  1. Tool Switcher
  2. Notifications Icon
  3. Profile link in the dropdown

image

Clicking the Top Left icon on the navbar will still navigate the user to https://platform.topcoder.com. Should this be disabled inside the onboarding flow?

Oanh-and-only-Oanh commented 3 years ago

Yes, let's disable Home on top left navbar.

On Mon, Nov 8, 2021 at 10:14 PM Rakib Ansary Saikot < @.***> wrote:

Assigned #82 https://github.com/topcoder-platform/micro-frontends-onboarding-app/issues/82 to @Oanh-and-only-Oanh https://github.com/Oanh-and-only-Oanh.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/topcoder-platform/micro-frontends-onboarding-app/issues/82#event-5587452061, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALKVPTRLPRJQXZK6Y647CWDULC337ANCNFSM5HUOLFXQ .

nursoltan-s commented 3 years ago

https://github.com/topcoder-platform/micro-frontends-navbar-app/pull/48

sandhiyakavi commented 3 years ago

@rakibansary Now the nav bar itself is completely hided. The user won't be able to even logout of the application. Is it expected?

Also the Firstname,Lastname are not correctly displayed now image

rakibansary commented 3 years ago

The NavBar should be visible. I'm not seeing the reported behaviour though

image

sandhiyakavi commented 3 years ago

@rakibansary If the onboarding procedure has already reached step 4 (complete) ,the nav bar is visible.

rakibansary commented 3 years ago

@sandhiyakavi this was an issue with navbar not rendering for users who has first name and/or last name undefined. https://github.com/topcoder-platform/micro-frontends-navbar-app/pull/51 should fix this issue.

sandhiyakavi commented 3 years ago

Verified in Prod Env. Working as expected.