search

topcoder-platform / onboarding-processor

Processor to act on various platform events to update the onboarding statuses of new users
1 stars 3 forks source link

Updates/deletes to profile settings are not shown in the response #14

Closed sdgun closed 3 years ago

sdgun commented 3 years ago

Steps Go to any users profile settings : https://www.topcoder-dev.com/settings/profile/ Update/delete an existing trait (ex- bio) Call {{URL}}/members//traits?traitIds=onboarding_checklist API See the response

the updated/deleted data are still displayed as true in the response

example user: taasintake6 Deleted data - bio & skills

Schpotsky commented 3 years ago

@veshu ,

  1. On which branch should the work be done feature/profile-completeness ?
  2. Do you want a PR for each issue ? or a single PR for all issues

cc @vikasrohit

vikasrohit commented 3 years ago

@Schpotsky separate PR for each issue would be better, but if single PR makes your life easy, go ahead with that as well. It is not strict yet. For branch please use develop branch for base work. You can create PR against develop as well as it is not feature now.

Schpotsky commented 3 years ago

@sdgun ,

For deleting bio, it should be fixed in this PR: #27

For skills, since there is no event published when skills got updated, we only check the skills flag if there is another profile or profile trait update

So, if you update skills, you need to update any of profile picture, bio, education work or language after it to fire an event to be processed by our processor

@vikasrohit , @veshu I do not have write access to this repository. So, I cannot add Ready for Review label to fixed issues

vikasrohit commented 3 years ago

Thanks @Schpotsky for the quick turnaround. skills is something we can not do much here without an event, agreed.

sdgun commented 3 years ago

@Schpotsky When delete all existing skills and make an update to any other setting(bio, education etc), the skills flag is still true in the response.

vikasrohit commented 3 years ago

@sdgun please log the skill deletion issue as separate issue now to track it better. As this seems to be a fairly rare use case, we can handle it after the release.

sdgun commented 3 years ago

Created https://github.com/topcoder-platform/onboarding-processor/issues/31

sdgun commented 3 years ago

Verified in production.