[$100] Some notifications are not received

[sdgun]

Didn't observe the below notifications coming:

Candidates are available for review (taas.notification.candidates-available-for-review) - Team - https://platform.topcoder-dev.com/taas/myteams/18973/positions/1448cb0c-fd69-4842-941f-7a3d934bdf52

Interview reminders-host/guest (hour before/day before) - (taas.notification.interview-coming-up-guest and taas.notification.interview-coming-up-host) hour before- https://platform.topcoder-dev.com/taas/myteams/18973/positions/cc3d0c21-f5e8-4def-bdd3-f776bf84ccc2 day before- https://platform.topcoder-dev.com/taas/myteams/18973/positions/4acdc735-43bb-4e4c-8c0c-1526e7d20f5c

Interview Completed: (taas.notification.interview-awaits-resolution) https://platform.topcoder-dev.com/taas/myteams/18973/positions/cc3d0c21-f5e8-4def-bdd3-f776bf84ccc2/candidates/interviews

Post Interview Action Reminder: (taas.notification.post-interview-action-required) https://platform.topcoder-dev.com/taas/myteams/18973/positions/cc3d0c21-f5e8-4def-bdd3-f776bf84ccc2/candidates/interviews

[maxceem]

This probably would be fixed by https://github.com/topcoder-platform/taas-apis/issues/618

[maxceem]

@sdgun this has to be fixed by https://github.com/topcoder-platform/taas-apis/issues/618 and is ready for QA

[sdgun]

@maxceem Still not getting these notifications, interview completed today and no email received on interview reminder, completion.

Ex- https://platform.topcoder-dev.com/taas/myteams/18976/positions/322a3141-4a96-4473-980f-2c67d2ca2e08/candidates/interviews

Also no email received on candidate available for review(https://platform.topcoder-dev.com/taas/myteams/18976)

Post Interview Action Reminder: - waiting till tommorrow to verify

[maxceem]

@yoution would you like to work on this?

I would need some good guidance on how to verify this locally. For example, this script may be updated to trigger all these notifications https://github.com/topcoder-platform/taas-apis/tree/dev/scripts/demo-email-notifications so it creates good demo data.

[yoution]

@maxceem please assign to me

[yoution]

@maxceem this issue show again https://github.com/topcoder-platform/taas-app/issues/576#issuecomment-981458959

[maxceem]

@sdgun this is ready for testing on DEV now.

Also, all other email notifications could be tested after this as we discussed on Slack.

[sdgun]

@maxceem I've verified all possible notifications so far and set up data for the remaining which I will test once I get the notifications during the day and weekly notifications on Monday.

[sdgun]

Below email notifications are not observed in the latest build too.

Candidates are available for review email is not received. taas.notification.candidates-available-for-review

Ex interviews: https://platform.topcoder-dev.com/taas/myteams/19334/positions/4633e6bf-b75f-41d8-a3fe-299e2d539174/candidates/to-review https://platform.topcoder-dev.com/taas/myteams/19333/positions/37d311be-0fc3-4edd-a01c-a1c04f8f6c80/candidates/to-review

Reminder: Take action to reserve your talent taas.notification.post-interview-action-required

Ex interviews: https://platform.topcoder-dev.com/taas/myteams/19333/positions/27aaeb62-dab5-4d4c-b960-7f58a6fa65fe/candidates/interviews

[maxceem]

@yoution some of the emails didn't come during testing on DEV https://github.com/topcoder-platform/taas-apis/issues/615#issuecomment-1001333253

[yoution]

@sdgun @maxceem Reminder: Take action to reserve your talent, what does it mean? does it mean we select the candidate from the popup? can you give me the email template like taas.notification.interview-awaits-resolution

[maxceem]

@yoution I've added email template ids into the comments above https://github.com/topcoder-platform/taas-apis/issues/615#issuecomment-1001333253

[yoution]

@maxceem will this status emit taas.notification.post-interview-action-required?

[maxceem]

@yoution no, only these statuses would emit it: Scheduled, Rescheduled, Completed, see https://github.com/topcoder-platform/taas-apis/blob/dev/src/services/NotificationsSchedulerService.js#L400-L402

[yoution]

@maxceem these emails can be created locally,I don't know why they can not emit these 2 templetes all use the user id https://github.com/topcoder-platform/taas-apis/blob/dev/src/services/NotificationsSchedulerService.js#L51 , I guess maybe the userids cause the issue

[maxceem]

ok @yoution I will check these users

[maxceem]

@sdgun regarding this one Reminder: Take action to reserve your talent the example JC is already selected so no Reminder: Take action to reserve your talent supposed to come. Or did you select this JC after you didn't get the email?

btw, to which user name did you expect to get these emails?

[maxceem]

@yoution that looks like a correct logic.

taas.notification.candidates-available-for-review - we send not to Job Candidate, but to the Team Members

and taas.notification.interview-awaits-resolution - we also send not to Job Candidate, but to the user who invited Job candidate for interview, see interview.hostUserId

[yoution]

@maxceem what is the value in dev? https://github.com/topcoder-platform/taas-apis/blob/dev/config/default.js#L310

[maxceem]

@yoution it should be the same like in this config

[sdgun]

@sdgun regarding this one Reminder: Take action to reserve your talent the example JC is already selected so no Reminder: Take action to reserve your talent supposed to come. Or did you select this JC after you didn't get the email?

btw, to which user name did you expect to get these emails?

@maxceem Somebody has selected the user 2hrs ago in the interview I provided in above comment, but if you check this one, it should have sent the email to user taasintake800 from 25th but it hasn't.

[maxceem]

@sdgun by any chance did you get email Candidates are available for review email is not received for any team during the last few days?

[sdgun]

@maxceem I haven't received such email for any of my teams.

[maxceem]

@yoution it seems that the issue is not in TaaS but in TC Notifications service. I see that TaaS sends Kafka events for these emails, but emails don't come. So we would check TC Notifications service.

[maxceem]

ignore

[maxceem]

I can see kafka events sent to tc-notifications service from TaaS:

• taas.notification.post-interview-action-required https://monosnap.com/file/we7JWxL6XdhJyDSAwESGEp39EJWTpw
• taas.notification.candidates-available-for-review https://monosnap.com/file/qrbZJ9QblfCg5jcbsqi2tbAdvEjQF4

Both these types of events use userId to send notifications. So I guess the problem is in TC Notifications - it fails to send email by userId though it should be able to do so.

[maxceem]

hey @sdgun

For the testing purpose could you please try creating a new Team using one of users who is not getting notifications and see if you would get Talent Request Confirmed email or no https://monosnap.com/file/sLXvXddBd3924e2VN5y03f7TcWy1Hq

[maxceem]

@sdgun I guess I found the issue. It was an issue with Sendgrid teampltes. I've fixed them and deployed so it could be tested on DEV now.

Details:

• Sendgrid handlebars template is limited. It doesn't support accessing elements in array by index, so the next code would not work and it would make the whole template in Sendgrid invalid:

  {{teamJobs.0.reviewLink}}
  {{teamInterviews.0.interviewLink}}

• I've removed such code from templates https://github.com/topcoder-platform/taas-apis/commit/1dcf0e0f7f009ebef370ff0656bb5c7edccb3437

[sdgun]

Verified, received 'Candidates are available for review' email and 'Reminder: Take action to reserve your talent' email.

[maxceem]

Challenge https://www.topcoder.com/challenges/1207c85a-8ec1-48a6-9c3b-2aef9838a194 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

[maxceem]

Challenge https://www.topcoder.com/challenges/1207c85a-8ec1-48a6-9c3b-2aef9838a194 has been assigned to yoution.

This is an automated message for maxceem via Topcoder X

[maxceem]

This ticket was not processed for payment. If you would like to process it for payment, please reopen it, add the tcx_FixAccepted label, and then close it again

This is an automated message for maxceem via Topcoder X

[maxceem]

Payment task has been updated: https://www.topcoder.com/challenges/1207c85a-8ec1-48a6-9c3b-2aef9838a194 Payments Complete Winner: yoution Copilot: maxceem Challenge 1207c85a-8ec1-48a6-9c3b-2aef9838a194 has been paid and closed.

This is an automated message for maxceem via Topcoder X