topcoder-platform / taas-app

TaaS App Front End
3 stars 24 forks source link

`Job` update and `Resource Booking` update should use `PATCH` instead of `PUT` #283

Open maxceem opened 3 years ago

maxceem commented 3 years ago

In the TaaS App we have the ability to:

Internally, when save update we use PUT request:

This appears to have a drawback. If we add some new field in the TaaS API but we don't update the form then fields that are not supported by the form would be reset to null and cause issue like this https://github.com/topcoder-platform/taas-apis/issues/260

Taks:

maxceem commented 3 years ago

QA guidelines:

sandhiyakavi commented 3 years ago

@maxceem Verified the following scenarios,

  1. Verified creating Job from Connect as well as Taas app, its getting created successfully.
  2. Verified Editing Job as well as RB form by clearing all the optional values, it's updating to null.

https://user-images.githubusercontent.com/55895538/119936253-d3ed3c00-bfc3-11eb-92bf-0f0c6ec5dd85.mp4

https://user-images.githubusercontent.com/55895538/119936268-d9e31d00-bfc3-11eb-8f6a-eafb1190da13.mp4

value updated to null RB_null