[$70] When a custom role is added, the job description is not saved

topcoder-platform / taas-app

TaaS App Front End

3 stars 24 forks source link

[$70] When a custom role is added, the job description is not saved #516

Closed sdgun closed 2 years ago

sdgun commented 2 years ago

Steps Go to JD flow and make a search with a job description which doesn't have skills matching any existing roles Proceed and create the team check the created position in TAAS TEAMS page

The job description is missing

CC @nikolay83

maxceem commented 2 years ago

Summary

The Job Description should depend on way customer creates a talent request https://platform.topcoder-dev.com/taas/createnewteam:

Search by Role - Should be the canned job description provided for the Roles (Java Spring, React, Data Engineer, Salesforce, etc)
Search by Skill - for now, just the list of skills
Describe the work - it should be the same Description which user entered during requesting a talent

Notes

I believe this previously worked before, but it seems that at some moment it got broken.
I'm not sure if the issue client side and/or server side. So if needed, you might also need to fix API https://github.com/topcoder-platform/taas-apis.

PR

This fix has to be done using master branch, so we could deploy fix to Production immediately after fixing and testing. If API need to be fixed, the fix has to be also applied to the master.

maxceem commented 2 years ago

@yoution @mbaghel if you believe that you can solve this issue during 12 hours, please, feel free to pick it up. The first who comments on this may start working immediately.

yoution commented 2 years ago

@maxceem please assign to me

maxceem commented 2 years ago

Sure, assigned @yoution

yoution commented 2 years ago

@maxceem please review

maxceem commented 2 years ago

@yoution when I create team using skills the job description is empty, see demo video https://monosnap.com/file/ewfGYjX5jorS9CzPcNtUDQUGdfCfhH. But it has to be a comma-separated list of skills.

Other 2 cases work good for me.

yoution commented 2 years ago

@maxceem did you deploy the tass-api project?

maxceem commented 2 years ago

ah, yes, my fault, I deployed it but forgot to change the API URL to local one, testing...

maxceem commented 2 years ago

Thank you @yoution it works good as per local testing, passing for QA.

@sdgun this issue is ready for testing on DEV https://platform.topcoder-dev.com/taas/createnewteam

sdgun commented 2 years ago

Verified all the 3 flows in Dev, the Job description is saved as expected.

maxceem commented 2 years ago

@yoution payment processed https://www.topcoder.com/challenges/d0fd7e23-35a1-472c-9d5d-2f2cec74460a.

sdgun commented 2 years ago

Verified in prod

https://user-images.githubusercontent.com/4592712/139045212-367d3c19-11ec-4cba-b3bf-2e73c77619f3.mp4