Open maxceem opened 2 years ago
Hi @maxceem! I am happy to work on this if you agree
Sure, assigned you @deblasis.
Hi @maxceem since you didn't specify otherwise, I was expecting to find the new design changes with the Nylas schedule interview "wizard" (as per your screenshot) merged to dev
already.
Just to make sure that I fully understand the scope of the changes can you please point out the source branches for taas-apis and taas-app ?
Cheers
hi @deblasis
In both repositories we have to use branch feature/interview-update
as mentioned in this guide https://github.com/topcoder-platform/taas-app/wiki/Run-TaaS-App-with-TaaS-API-locally-to-test-Interview-Scheduling-using-Nylas
@maxceem please assign to me
@maxceem please ask others to finish this one, I don't have time to finish it
@yoution if we extend time till tomorrow end of the day, would it help you?
@maxceem , sorry, I am not familiar with Google/Microsoft, to configure these two apps will waste me a lot of time, I hope others can help you
got it @yoution, no problem
The payment for this issue has been raised to $175.
@deblasis, @mahidulalvi-bonic if you would like to work on this issue and can complete it by Tuesday 26 October 9am GMT+3
, just let me know in comment and you may start working on it.
@maxceem , I can work on it.
Sure, assigned to you @mahidulalvi-bonic
Thanks.
Hi @maxceem , the requirement 1 says, "As redirectTo set URL to the current page + add ?interviewWithCandidate={jobCandidateId}, example https://platform.topcoder-dev.com/taas/myteams/18907/positions/a14d4946-418c-4329-998e-918603348fe2/candidates/interviews?interviewWithCandidate=8b0346e8-76bd-4c8c-b378-d27d3ce24262"
Here, the example url has '...candidates/interviews' but when I run the app the url is '.../candidates/to-review'. Should I use the one in the app?
@mahidulalvi-bonic yeah, it has to be the one in the app.
In App we could schedule interview from at least 2 pages:
So whatever the current URL is we have to add ?interviewWithCandidate=8b0346e8-76bd-4c8c-b378-d27d3ce24262
with Job Candidate id which we choose, so redirectTo
might become:
Depend on what is the current URL.
@maxceem , should the JWT token in the 'state' param have any expiry? If so, how long should it be?
And in case, jwt is not verified due to expiry/invalid secret, how should it work? Should it show an error from API in blank page like: {"message":"Could not verify JWT token."}, or should it try to look into jwt without verifying, and use the redirectTo to redirect back? This may require additional sanitising.
Hi @maxceem , I sent another demo video in your email.
Hi @mahidulalvi-bonic no need to make it expired or verification. Basically for now we are only using it to compress the data we pass, because state has very limit length, and using JWT we can compress a big object.
Thank you @mahidulalvi-bonic all works good. Payment is processed https://www.topcoder.com/challenges/502cfdda-859b-42de-b772-d6022be7cff3
No problem, thanks.
@mahidulalvi-bonic @maxceem Seeing the below error when trying to connect the calender
Error
Sorry, an error occurred :(
Status 500:
An internal error occurred. If this issue persists, please contact support and copy/paste this request_uid: "A29E1630:6E28_0A4D0942:01BB_617F6B7B_35ABE:2568".
https://user-images.githubusercontent.com/4592712/139621417-cf97c8c1-413b-4005-8b50-0d1b1f739314.mp4
@maxceem While trying the same above scenario, I am getting a different error "{"message":"Could not verify JWT token."}" at the api level.
Note: But the Google account connected successfully when I tried to schedule interview again by Connecting to the Google account
Thank you @sdgun @sandhiyakavi
We would try to debug it. If you happen to have such issues again, could you please, copy/paste the URL from the browser which you had when error happens. It might help debugging it.
@sdgun regarding your issue during connecting calendar. I see that you are using email taasintake3@gmail.com
. I wonder if you ever used the same email with +
sign like taasintake3+something@gmail.com
?
I've noticed that if we use with Nylas email with +
then if we try to connect calendar with the same email with +
or without +
it got broken.
So we always have to use real different emails we cannot use the same email with +
because it points to the same Google account and lead to such issues.
cc @sandhiyakavi just in case
@sandhiyakavi could you, please, try testing it one more time. Your issue has to be resolved now.
@maxceem So far I only had this issue with taasintake3 which I have used with a + to create another user. I will check with some more users tommorrow.
@maxceem Verified. I am not getting TokenExpiredError now.
@maxceem Tried with a fresh user today and I am seeing these errors, also we don't get the interview booked email anymore
https://user-images.githubusercontent.com/4592712/139788948-e7bbfc78-df1b-4fb0-8a51-01005a559d03.mp4
@sdgun does this error happen if you select calendar permissions from the first time without going back?
@maxceem Yes
@maxceem Don't see any of the errors seen in the above comment video anymore, but the first time a new user connecting calender, always got the below error and it didn't connect the calender. But it worked second time.
Error: Could not find any writable calender
https://user-images.githubusercontent.com/4592712/140027082-6dcbe21f-9719-4a40-a32e-60ee31056629.mp4
Hi @maxceem, just saw this, I encountered this issue when creating new users in Exchange and it used to go away after some time but usually happened just after creating Exchange account.
@mahidulalvi-bonic I did some debugging and it looks likes a Nylas issue. At the moment when it redirects us to API the calendar is not yet returned by Nylas API. But if we try to get it after some time it’s there. I’ve reported it to Nylas support and waiting for response.
Thank you @sdgun @sandhiyakavi
We would try to debug it. If you happen to have such issues again, could you please, copy/paste the URL from the browser which you had when error happens. It might help debugging it.
@maxceem I got this sporadically again, here is the url:
https://user-images.githubusercontent.com/4592712/140510573-7a77a306-1f3e-4f12-b25c-4a85c7f738f4.mp4
Thank you for the demo video @sdgun. By any chance did you ever use the same email with +
sign? like taasintake11+somthing@gmail.com
.
@maxceem As far as I remember I haven't used it
@maxceem We still have https://github.com/topcoder-platform/taas-app/issues/519#issuecomment-958729774, I guess this has not been addressed yet
@maxceem We still have #519 (comment), I guess this has not been addressed yet
Yeah, it still has to be fixed. I created a separate issue to track it https://github.com/topcoder-platform/taas-app/issues/580.
Is this the only one thing which left not working here?
@maxceem We are waiting for connect Microsoft calender testing, if it is handled in a separate ticket that's all the issues for this
@sdgun got it. I've created a separate issue for Microsoft calendar for easier tracking, so it's clear what has to be done https://github.com/topcoder-platform/taas-app/issues/581
Removing the milestone since this feature was disabled in the current production release https://github.com/topcoder-platform/taas-app/issues/598
Recently we've implemented Connect Calendar feature in API in this challenge https://www.topcoder.com/challenges/af9a1041-7a78-484d-87d3-5aec9e87b578?tab=details
Now we would like to integrate it with UI.
To work on this task you would have to run locally TaaS API and TaaS App as per this guide.
General Logic
Task
redirectTo
set URL to the current page + add?interviewWithCandidate={jobCandidateId}
, examplehttps://platform.topcoder-dev.com/taas/myteams/18907/positions/a14d4946-418c-4329-998e-918603348fe2/candidates/interviews?interviewWithCandidate=8b0346e8-76bd-4c8c-b378-d27d3ce24262
?interviewWithCandidate={jobCandidateId}&calendarConnected=true
?interviewWithCandidate={jobCandidateId}&calendarConnected=true
from URL?interviewWithCandidate={jobCandidateId}&calendarConnected=false&error={errorReason}
?interviewWithCandidate={jobCandidateId}&calendarConnected=false&error={errorReason}
from URLVerification
Provide demo video(s) showing both cases: calendar connected successfully or failed.