search

topcoder-platform / taas-app

TaaS App Front End
3 stars 24 forks source link

Remove button is still present even after the Email account is removed. #561

Open sandhiyakavi opened 2 years ago

sandhiyakavi commented 2 years ago

Description: Remove button is still present even after the Email account is removed.

https://user-images.githubusercontent.com/55895538/139641014-083945be-079a-449b-a0e5-3e3fa3f52969.mp4

image

maxceem commented 2 years ago

@mahidulalvi-bonic would you like to handle this issue?

ghost commented 2 years ago

@maxceem, yes, when do you need it?

maxceem commented 2 years ago

@mahidulalvi-bonic preferable within 24 hours. But 48 would be also fine for this one.

ghost commented 2 years ago

Okay, should be done in 24. Thanks.

ghost commented 2 years ago

Hi @maxceem, I couldn't reproduce the issue using a Gmail & an Exchange account. From the video, it seems the screen still works like it used to before I worked on the delete functionality. And I also saw new changes in the dev branch, is it possible this is a regression?

I tried with dev branch of taas-app & taas-apis.

maxceem commented 2 years ago

hi @mahidulalvi-bonic I'm not sure if this is regression issue or existent issue which started showing up.

Did you try this on DEV https://platform.topcoder-dev.com/taas/myteams/16786/positions/e7c0d8c0-3e88-46ab-babf-55699bc7a8e6/candidates/interviews without running it locally?

I can see some warning in browser console which might be related: react-dom.development.js:82 Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function. in Ju (created by Xd)

ghost commented 2 years ago

@maxceem, I just tried in dev with an Exchange account in the URL you gave above. Couldn't reproduce the issue.

ghost commented 2 years ago

I did try in incognito, could it be that you have an older version of the app installed?

maxceem commented 2 years ago

could it be that you have an older version of the app installed?

Not sure which app you mean, when we use link https://platform.topcoder-dev.com/taas/myteams/16786/positions/e7c0d8c0-3e88-46ab-babf-55699bc7a8e6/candidates/interviews we (I mean you and me) use the same version of TaaS App. Strange that it happens to me, but not to you.

If you cannot reproduce this issue, I guess you might leave it as I don't have other ideas why it is reproducible for me, but not for you.

ghost commented 2 years ago

Here is a recording how I saw

https://user-images.githubusercontent.com/92695808/140295492-601903e1-c3fe-485a-a89c-f66242f6b194.mp4

ghost commented 2 years ago

It could be a cached version of the web app.. Maybe try deleting all app data & cache from application tab in dev tools?

maxceem commented 2 years ago

It seems that for me it also doesn't happen every time. I tried it one more time and it worked good this time (even without cleaning cache), though I could still see warning in the browser console:

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.
    in Ju (created by Xd)
ghost commented 2 years ago

@maxceem, it would be great if you could make a short video of it, with the console and network tabs shown in dev tools. I still couldn't reproduce it.

maxceem commented 2 years ago

@mahidulalvi-bonic unassigning you for now as I also cannot reproduce it now.

@sdgun could you please try one more time? It seems that this issue has been fixed by fixing some other issue.

sdgun commented 2 years ago

@maxceem Tried with few users, this is not reproduced.

maxceem commented 2 years ago

Ok marking it as passing QA for now, but feel free to fail it again if you see this issue happen again.