Open sdgun opened 2 years ago
Sum up:
sendInterviewScheduleReminderNotifications
is triggered each day the same time. so all notification are send at the same time.interview. createdAt
sendInterviewComingUpNotifications
CRON_INTERVIEW_SCHEDULE_REMINDER
to '/5 *' - so it run every 5 minutescreatedAt
from now (including now) till 5 minutes later (not including)Notification Demo
so we can trigger this notification from Postman https://monosnap.com/file/3yifghvTy4mk5D0L8C1216W4dn4Cbl (don't break other).@yoution this is also ready to pick up.
@maxceem pleaae assign to me
@yoution it appears that this issue is blocked by another one https://github.com/topcoder-platform/taas-apis/issues/618.
Please, hold on working on this issue until the other one is fixed, we are working on that.
@yoution you may keep working on this issue, as blocking issue https://github.com/topcoder-platform/taas-apis/issues/618 has been fixed.
@maxceem you said we should seach the interviews by startTimestampt
,
but the status of current interview is scheduling
, I think we should search by createdAt
, please confirm?
@yoution you are right we have to use createdAt
- updated task description.
@maxceem can we don't work on these two tasks
Update demo script
: we should update the createdAt
to currentTime, but it seems we can't modify this field,https://github.com/topcoder-platform/taas-apis/blob/dev/scripts/demo-email-notifications/index.js#L72 , is it readonly?Update Postman
: I think create interview
is enoughok @yoution, no need
Hey, @yoution I've checked your PR, I think my task was not clear.
INTERVIEW_REMINDER_DAY_AFTER
) after the interview was created. So if the user was invited but didn't reply - we send a reminder.INTERVIEW_REMINDER_DAY_AFTER
we have to send this reminder every day (configured by INTERVIEW_REMINDER_FREQUENCY
)Previously it was implemented like this, but it sent reminders at the same time for all people. But we have to count time from createdAt
for each individual interview.
I would update the payment for this task to $100, would you be willing to update it accordingly?
The issues are fixed.
Challenge https://www.topcoder.com/challenges/cd80fe0a-4073-42bd-8e24-7257d82ffd4a has been created for this ticket.This is an automated message for maxceem via Topcoder X
Challenge https://www.topcoder.com/challenges/cd80fe0a-4073-42bd-8e24-7257d82ffd4a has been assigned to yoution.This is an automated message for maxceem via Topcoder X
Payment task has been updated: https://www.topcoder.com/challenges/cd80fe0a-4073-42bd-8e24-7257d82ffd4a
Payments Complete
Winner: yoution
Copilot: maxceem
Challenge cd80fe0a-4073-42bd-8e24-7257d82ffd4a
has been paid and closed.This is an automated message for maxceem via Topcoder X
Observed the below issues in in interview schedule reminder notification:
Issue 1
All reminder emails related to different interviews were sent at the same time irrespective of their start time, is there a scheduled time to send this or is it ssent after like 1 hour of the selected start time?
https://user-images.githubusercontent.com/4592712/140261218-0c15e2c1-81ae-439b-9139-46ba591d1c1b.mp4
Issue 2
'minutes' text is missing