topcoder-platform / taas-app

TaaS App Front End
3 stars 24 forks source link

[$50] When trying to connect to zoom, an incorrect interview time is shown #593

Open sdgun opened 2 years ago

sdgun commented 2 years ago

Steps Schedule an interview Go to JC's email Click the zoom link in the Candidate confirmed meeting on... email Check the time

incorrect interview time is shown

All Interviews here: https://platform.topcoder-dev.com/taas/myteams/19320/positions/c8511efd-af2d-46ee-a86d-59d291bee61e/candidates/interviews

https://user-images.githubusercontent.com/4592712/145806325-192532ee-41fb-416b-937d-7f5acbe58c90.mp4

maxceem commented 2 years ago

@sdgun just to confirm. Asia/Colombo is your current timezone when testing, right? So when it says interview is scheduled for 2pm Asia/Colombo you are expecting that Zoom would also show the same 2pm because you are now in Asia/Colombo timezone, right?

sdgun commented 2 years ago

@sdgun just to confirm. Asia/Colombo is your current timezone when testing, right? So when it says interview is scheduled for 2pm Asia/Colombo you are expecting that Zoom would also show the same 2pm because you are now in Asia/Colombo timezone, right?

@maxceem yeah, I was expecting to see 2pm.

xxcxy commented 2 years ago

Created a MR https://github.com/topcoder-platform/taas-apis/pull/644 to fix this.

maxceem commented 2 years ago

@sdgun this issue has been fixed and is ready for testing on DEV.

Here is a comment regarding the fix:

A zoom meeting can only set one timezone when creating, and the only join url will show the waiting page, so I set the meeting timezone to the guest timezone.

sdgun commented 2 years ago

This issue is not fixed yet, checked by scheduling a new interview

Interview: https://platform.topcoder-dev.com/taas/myteams/19320/positions/eef4ac23-5ca8-46ed-be05-4c0ee034432e/candidates/interviews JC - taasintake300

https://user-images.githubusercontent.com/4592712/146351681-e16dc59f-39bc-44da-ac0d-fabe3d5b7ebd.mp4

maxceem commented 2 years ago

@xxcxy it looks like this issue is not yet fixed, could you please have a look https://github.com/topcoder-platform/taas-app/issues/593#issuecomment-995625140

xxcxy commented 2 years ago

Sure, I will check it. I want to confirm is the new meeting is fine? looks the video is a rescheduled meeting.

sdgun commented 2 years ago

Sure, I will check it. I want to confirm is the new meeting is fine? looks the video is a rescheduled meeting.

The new meetings has the same issue @xxcxy

xxcxy commented 2 years ago

Sorry, I don't understand. I check it and looks it show correct. https://monosnap.com/file/ROrXOUIFzX3gAIwxJHd56mDIzksd3O

xxcxy commented 2 years ago

In the second video, you computer timezone is different from email timezone. The zoom client will show the time from your computer timezone.

sdgun commented 2 years ago

In the second video, you computer timezone is different from email timezone. The zoom client will show the time from your computer timezone.

@xxcxy There is no TZ named 'Asia/colombo time zone' in windows, what I use is 'Sri Jayawardenapura' which is also GMT+5:30(same as IST)

xxcxy commented 2 years ago

I'm not sure whether it's the zoom client issue, could you try Asia/Kolkata timezone, if windows has timezone like this.

sdgun commented 2 years ago

@xxcxy I checked by changing the TZ to Asia/Kolkata, still see a different time

https://user-images.githubusercontent.com/4592712/146625943-24b55331-fea1-41a7-a004-df8fba28fb77.mp4

xxcxy commented 2 years ago

My last MR, I forgot to update the reschedule code, so the reschedule process may have timezone problem. I fix it in this MR https://github.com/topcoder-platform/taas-apis/pull/646 . But this just determine the timezone of start time we send to zoom. How to show this time depends on zoom client. I tried Asia/Shanghai and Europe/London in my computer and it shows correctly.

maxceem commented 2 years ago

But this just determine the timezone of start time we send to zoom. How to show this time depends on zoom client. I tried Asia/Shanghai and Europe/London in my computer and it shows correctly.

hmm, @xxcxy, so what you are saying is, that we actually don't have to use any specific timezone when creating a zoom meeting? We just can avoid setting timezone, pass time in UTC+0, and it should adjust to the client timezone of the one who opens the link?

maxceem commented 2 years ago

As from Zoom API docs:

image

So it looks like we just have to pass the time in the correct format yyyy-MM-ddTHH:mm:ssZ which means GMT 0, and Zoom client would show the correct date depend on the computer timezone.

Is that right?

xxcxy commented 2 years ago

Yes, I tried if I set different timezone in my computer and restart the zoomMeeting client, it shows different time like the doc said. But if i don't set timezone when sending api, the client shows the time different from the email even they have same timezone. So i think we should set the timezone.

maxceem commented 2 years ago

Ok. So I guess sdgun still can reproduce the issue because in this:

image

But it seems that there could be an easier solution than using candidate timezone:

And then the client would render the time we set in UTC using computer timezone. Would this work?

xxcxy commented 2 years ago

No, I tried "UTC", at least it can't work in my computer. The time showed different from email.

maxceem commented 2 years ago

Hmm, could it be that toISOString returns date not in the same format that is expected by Zoom?

xxcxy commented 2 years ago

I'm not sure. Since I can't reproduce it in my computer and my zoomAccount. I need confirm something to infer what's the problem.

  1. if sdgun change the computer timezone, the zoom client shows different time?
  2. what the actual time sdgun set and whether the email show time is right?
maxceem commented 2 years ago

@sdgun there are some details which might help to find the root cause of the issue https://github.com/topcoder-platform/taas-app/issues/593#issuecomment-997373702.

I guess a video showing the whole process including scheduling, selecting time and opening the final zoom link might help.

sdgun commented 2 years ago

@maxceem @xxcxy Here is the video

Interview zoom time.zip

sdgun commented 2 years ago

@xxcxy Looks like the time is shown in GMT in Nylas and zoom, for example in the timeslots payload, the starttime and endtime stamps are sent when the user schedules the interview, for example in the below interview, JC scheduled the interview to 1pm-1.30pm on 25th Dec in IST, which is 7.30am-8am in GMT and that is what the Nylas/zoom shows to the JC while trying to connect the meeting.

https://user-images.githubusercontent.com/4592712/146877252-a9218514-331a-4dc8-a23c-f607b613fff1.mp4

You can see the time changing in scheduling page after submitting clearly in this video:

https://user-images.githubusercontent.com/4592712/146878827-a4deffc2-0183-4403-87b0-9d0a6082a4ab.mp4

xxcxy commented 2 years ago

Yes. I think the request parameters is very helpful, I will try to reproduce this issues in my local, If i can reproduce it, i think i can resolve it.

xxcxy commented 2 years ago

Hmm, could it be that toISOString returns date not in the same format that is expected by Zoom?

  • 2011-10-05T14:48:00.000Z
  • if we set timezone, then there should not be .000Z

Yes, You are right. Fixed in this MR https://github.com/topcoder-platform/taas-apis/pull/649

maxceem commented 2 years ago

@sdgun a new fix has been deployed to DEV and is ready for testing.

sdgun commented 2 years ago

Unable to verify due to https://github.com/topcoder-platform/taas-app/issues/596

sdgun commented 2 years ago

Verified in dev env, the time is displayed correctly now.

https://user-images.githubusercontent.com/4592712/147059823-6ed47db8-4dfa-48ad-b4af-b7d5dab051c2.mp4

maxceem commented 2 years ago

Challenge https://www.topcoder.com/challenges/f9030ea9-8a63-437a-9957-8013bd8e91ea has been created for this ticket.

This is an automated message for maxceem via Topcoder X

maxceem commented 2 years ago

Challenge https://www.topcoder.com/challenges/f9030ea9-8a63-437a-9957-8013bd8e91ea has been assigned to xxcxy.

This is an automated message for maxceem via Topcoder X

maxceem commented 2 years ago

Payment task has been updated: https://www.topcoder.com/challenges/f9030ea9-8a63-437a-9957-8013bd8e91ea Payments Complete Winner: xxcxy Copilot: maxceem Challenge f9030ea9-8a63-437a-9957-8013bd8e91ea has been paid and closed.

This is an automated message for maxceem via Topcoder X

maxceem commented 2 years ago

Thank you @xxcxy it works now, and payment has been processed.