search

topcoder-platform / tc-notifications

4 stars 15 forks source link

updated image link to point to connect-app static resources #116

Closed akumar1503 closed 5 years ago

akumar1503 commented 5 years ago

For this issue on connect app.

updated image link to point to connect-app static resorces in email templates.

maxceem commented 5 years ago

@vikasrohit this PR looks good to me.

I think it can be merged.

To apply changes we should do 2 things:

  1. Deploy cf17 which contains this PR which implement serving static files inside Connect App.
  2. Update all the templates from this repository inside the Sendgrid.
vikasrohit commented 5 years ago

Thanks @maxceem. We will merge the cf17 as per our schedule i.e. after closing the challenge. What exactly we need to change in templates? We only have one template and you can do that changes here.

maxceem commented 5 years ago

@vikasrohit yes, the changes are already done in this PR we are commented to. You can have a look on the changed files https://github.com/topcoder-platform/tc-notifications/pull/116/files

vikasrohit commented 5 years ago

Thanks for pointer., I thought I am commenting on connect-app issue 😬. Will merge this PR when we merge the cf17 in connect-app.