search

topcoder-platform / tc-notifications

4 stars 15 forks source link

New user roles #152

Closed maxceem closed 4 years ago

maxceem commented 4 years ago

Support of new user roles as per https://github.com/appirio-tech/connect-app/issues/3298

New user roles with "manager" level project roles have the same configuration as existent users with project "manager" role.

I've tested this locally, works good. I can see new notifications created for the user with new role in the DB.

vikasrohit commented 4 years ago

@maxceem I think we can add BDR user role to https://github.com/topcoder-platform/tc-notifications/blob/3d8b02ec575dcb6172128f38464f145bc2e81650/connect/events-config.js#L68 so that they receive the emails for project's submitted for review. Similarly BDR should get emails for newly created projects as well (https://github.com/topcoder-platform/tc-notifications/blob/3d8b02ec575dcb6172128f38464f145bc2e81650/connect/events-config.js#L61), which might get obsolete after we implement changes to remove draft status altogether.

maxceem commented 4 years ago

Nice catch @vikasrohit I've missed this role. PR is updated for both cases to keep the current code consistent.