search

topcoder-platform / tc-notifications

4 stars 15 forks source link

[Hotfix] [Dev] fix duplicates in emails #157

Closed maxceem closed 4 years ago

maxceem commented 4 years ago

Fix for the issue which is tracked in Connect App https://github.com/appirio-tech/connect-app/issues/3216

Additionally, make a fix for a potential issue. See commit message for details.

vikasrohit commented 4 years ago

Just to confirm @maxceem we are not merging this hotfix to master, right?

maxceem commented 4 years ago

Just to confirm @maxceem we are not merging this hotfix to master, right?

I was thinking that we would like to merge it to master as a hotfix. Looks like I've accidentally created it agains the dev.

vikasrohit commented 4 years ago

Okay, if we have the front end changes for it in our next hotfix for 2.4.15.2, we can create hotfix against master for this repo as well. No issue with that as well.

maxceem commented 4 years ago

Okay, if we have the front end changes for it in our next hotfix for 2.4.15.2, we can create hotfix against master for this repo as well. No issue with that as well.

This issue only requires changes in the tc-notifications repo in this PR. No frontend changes are required. So it can be merged now as a hotfix, or it can be wait until the next release of the tc-notificatons repo if this issue is not urgent.

vikasrohit commented 4 years ago

Okay. Lets create hotfix for it against master as well. We would merge it with Connect 2.4.15.2

maxceem commented 4 years ago

Here is PR against master https://github.com/topcoder-platform/tc-notifications/pull/158