search

topcoder-platform / tc-notifications

4 stars 15 forks source link

update: improve universal notifications payload #216

Closed eisbilir closed 3 years ago

eisbilir commented 3 years ago

Thanks, @maxceem for the feedbacks,

Inside searchUsersByEmailQuery method, let's also try catch the const res = yield request to catch issues during network request like it's done in other methods.

caller method has try catch https://github.com/eisbilir/tc-notifications/blob/feature/universal-notifications/src/common/tcApiHelper.js#L146-L153

I've fixed the other issues and ready to push, If above issue is okay.

while searching by userIds and handles, I combined them into one query and make the search call at once. But for emails and uuids, it doesn't allow to make multiple searches with one call. And we have to make 2 seperate calls for each person while trying to find email by uuid

maxceem commented 3 years ago

If above issue is okay.

@eisbilir got it, then the second try/catch is not required, please push the update.