search

topcoder-platform / tc-notifications

4 stars 15 forks source link

connect.action.timeline.adjusted is not handled #72

Open maxceem opened 5 years ago

maxceem commented 5 years ago

connect.action.timeline.adjusted event is generated in tc-project-service https://github.com/topcoder-platform/tc-project-service/blob/dev/src/constants.js#L104 and is handled in connect-app https://github.com/appirio-tech/connect-app/blob/dev/src/routes/notifications/constants/notifications.js#L509.

But it's not handled in tc-notifications thus won't appear in connect-app.

maxceem commented 5 years ago

@vikasrohit FYI, I'll send this event connect.action.timeline.adjusted only to copilot/manager users. Let me know if owner/member also have to get it.

vikasrohit commented 5 years ago

I guess, as this notification is going to be hidden for all users, we can listen it for all users. It would allows us to show the visual cue for customers as well which I think is more important because mostly it would a copilot/manager who would be doing the changes and customer needs to know that there is a change in the timeline.

maxceem commented 5 years ago

@vikasrohit created a PR https://github.com/topcoder-platform/tc-notifications/pull/73

vikasrohit commented 5 years ago

@maxceem PR is merged, let me know if you are still seeing any issue with this event.

maxceem commented 5 years ago

@vikasrohit by the code it seems everything is ok, but this event connect.action.timeline.adjusted doesn't come to me in Connect app, even though I can see this event is generated by tc-project-service. I've tried to reproduce it locally by deploying tc-notification, but it depends on tc-project-service so it's a little bit hard to test it locally.

maxceem commented 5 years ago

@vikasrohit this event comes to Connect now. So this issue is fully resolved now.