Navigation should NOT go below footer

topcoder-platform / timeline-wall-api

Topcoder timeline wall back end APIs and support code

0 stars 1 forks source link

Navigation should NOT go below footer #20

Open Dara-K opened 2 years ago

Dara-K commented 2 years ago

When scrolling down, navigation should not go under the footer area.

igoroshko commented 2 years ago

@Dara-K can we combine it with the #6 ?

Dara-K commented 2 years ago

Yes

suppermancool commented 1 year ago

@igoroshko done in https://github.com/topcoder-platform/community-app/pull/6736

Dara-K commented 1 year ago

@igoroshko Testing this and it shows that it still goes below the footer:

suppermancool commented 1 year ago

@igoroshko done in https://github.com/topcoder-platform/community-app/pull/6740

igoroshko commented 1 year ago

@suppermancool thanks!

@Dara-K it is now available on Dev environment for verification.

Dara-K commented 1 year ago

Okay then I am looking forward to see it live.

igoroshko commented 1 year ago

@suppermancool we have a clarification in the requirements. Can we please update it, so that there is 80px spacing between navigation bar and the footer when scrolled down?

suppermancool commented 1 year ago

@igoroshko done in https://github.com/topcoder-platform/community-app/pull/6743