topcoder-platform / timeline-wall-api

Topcoder timeline wall back end APIs and support code
0 stars 1 forks source link

Attachment text length limit only softly enforced #23

Closed penatrix-tc closed 1 year ago

penatrix-tc commented 1 year ago

- feel free to remove this issue

igoroshko commented 1 year ago

@penatrix-tc actually, it is enforced on the backend too, but frontend doesn't handle errors well. And looks like on backend limit is different. I'll also create issue to handle backend errors:

image

penatrix-tc commented 1 year ago

That's good! I only had access to the frontend while testing, so I couldn't be sure

igoroshko commented 1 year ago

To test this, please right click on the description box and select Inspect, then remove the length attribute from the textarea element. This will bypass frontend validation, so you can now enter text into textbox which exceeds 240 chars. Once event is submitted, you should get validation error from backend.

image

Dara-K commented 1 year ago

Thanks for the instructions @igoroshko This works! I can see the backend message. Can we change the error message to be red this color #EF476F? and instead of "CONFIRMATION" write "ERROR" image

igoroshko commented 1 year ago

@Dara-K created new ticket for that - #32