topcoder-platform / work-manager

This is the frontend application for creating and managing challenges.
13 stars 48 forks source link

When there is a space after a sentence, highlighting and adding effects are applied to all the text below #1503

Closed jmgasper closed 1 year ago

jmgasper commented 1 year ago

REF: https://topcoder.atlassian.net/browse/PROD-4123

  1. Go to WM
  2. Add a sentence in the editor with a space at the end
  3. Add some more sentences below it by pressing enter key
  4. Now select the first line by double clicking it
  5. Apply some font effect
  6. When there is a space after a sentence, highlighting and adding effects are applied to all the text below

Video

https://user-images.githubusercontent.com/21790/220463456-829e38a6-6561-4509-89f9-c7ef2041f0fd.mp4

suppermancool commented 1 year ago

@jmgasper I can not fix this bug this is the bug in easymde https://github.com/Ionaru/easy-markdown-editor/issues/74 it is related to how CodeMirror displays the template

The only thing I can do is add ** before all the spaces at the end of the selection text. Is this ok?

suppermancool commented 1 year ago

@jmgasper this is demo for above suggestion https://monosnap.com/file/Duv8Gj4HN4fI6kvMq3RCO4YozXdhqE

jmgasper commented 1 year ago

@suppermancool - Thanks. I'll get feedback from Topcoder first and let you know.

jmgasper commented 1 year ago

This tweak will work. $40 still OK?

On 22 Feb 2023 at 11:20:10 am, suppermancool @.***> wrote:

@jmgasper https://github.com/jmgasper this is demo for above suggestion https://monosnap.com/file/Duv8Gj4HN4fI6kvMq3RCO4YozXdhqE

— Reply to this email directly, view it on GitHub https://github.com/topcoder-platform/work-manager/issues/1503#issuecomment-1439261534, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAFKHQMO7SLZVE6LJGSDUDWYVLTVANCNFSM6AAAAAAVDRNBXY . You are receiving this because you were mentioned.Message ID: @.***>

suppermancool commented 1 year ago

yes. it is ok On Thu, 23 Feb 2023 at 06:49 Justin Gasper @.***> wrote:

This tweak will work. $40 still OK?

On 22 Feb 2023 at 11:20:10 am, suppermancool @.***> wrote:

@jmgasper https://github.com/jmgasper this is demo for above suggestion https://monosnap.com/file/Duv8Gj4HN4fI6kvMq3RCO4YozXdhqE

— Reply to this email directly, view it on GitHub < https://github.com/topcoder-platform/work-manager/issues/1503#issuecomment-1439261534 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAAFKHQMO7SLZVE6LJGSDUDWYVLTVANCNFSM6AAAAAAVDRNBXY

. You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/topcoder-platform/work-manager/issues/1503#issuecomment-1441014131, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMLXDWWL77DM6NUPJ2SDO3WY2QY3ANCNFSM6AAAAAAVDRNBXY . You are receiving this because you were mentioned.Message ID: @.***>

-- Best regards,

Diazz.

suppermancool commented 1 year ago

@jmgasper done in work-manager-issue-1503.patch this patch against commit 8be49cf2dbb2c7fca8a923fce83a5d60e2311bef (develop branch)