[$60] Fix up the Gantt charts

topcoder-platform / work-manager

This is the frontend application for creating and managing challenges.

13 stars 47 forks source link

[$60] Fix up the Gantt charts #175

Closed jmgasper closed 4 years ago

jmgasper commented 4 years ago

@suppermancool - We need to fix up the Gantt charts a bit:

Issue 1

The chart on the new challenge page is rendering differently than the edit challenge page. Ideally, these would be the same:

New challenge

Screen Shot 2020-04-27 at 12 26 11

Edit challenge

Screen Shot 2020-04-27 at 12 25 57

Issue 2

In terms of the phase duration, I got this clarification, so we can got with this assumption:

go now with the assumption that phase duration is hours

jmgasper commented 4 years ago

Contest https://www.topcoder.com/challenges/30123335 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

jmgasper commented 4 years ago

Contest https://www.topcoder.com/challenges/30123335 has been updated - it has been assigned to diazz.

This is an automated message for ghostar via Topcoder X

suppermancool commented 4 years ago

@jmgasper in the existing code if the backend return missing data or when create new challenge the frontend will calculate the challenge timelines locally.
For this i will:

Hide the timeline if the backend return broken phase.
In create new challenge i will hide the timeline until getting the response of first request of creating new draft challenge.

is this ok?

jmgasper commented 4 years ago

Yep, that sounds good, thanks

suppermancool commented 4 years ago

@jmgasper done in https://github.com/topcoder-platform/challenge-engine-ui/pull/180. i removed all local calculation for timeline, the timeline should come from backend now

jmgasper commented 4 years ago

@suppermancool - I don't see issue 2 address - this still seems to be in seconds.

suppermancool commented 4 years ago

@jmgasper do you have any challenge that have duration?

jmgasper commented 4 years ago

@suppermancool - I'm investigating. I'll get back to you.

suppermancool commented 4 years ago

@jmgasper done in https://github.com/topcoder-platform/challenge-engine-ui/pull/182 We only use duration for calculating the Percent done:

The duration you see in that popup = Phase.scheduledEndDate - Phase.scheduledStartDate

jmgasper commented 4 years ago

@suppermancool - Thanks. I think that we have to do something here, but I'm not exactly sure what. I'm attempting to get clarification from the challenge API side.

jmgasper commented 4 years ago

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30123335

This is an automated message for ghostar via Topcoder X