topcoder-platform / work-manager

This is the frontend application for creating and managing challenges.
13 stars 47 forks source link

[$300] Integrate Attachments with the API #68

Closed ThomasKranitsas closed 5 years ago

ThomasKranitsas commented 5 years ago

Currently, the Attachments section is hidden. You need to fix it so it's visible when in edit mode and integrate it with the API.

Swagger: https://github.com/topcoder-platform/challenge-api/tree/develop/docs

ThomasKranitsas commented 5 years ago

Contest https://www.topcoder.com/challenges/30093882 has been created for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

ThomasKranitsas commented 5 years ago

Contest https://www.topcoder.com/challenges/30093882 has been updated - the new changes has been updated for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

ThomasKranitsas commented 5 years ago

Contest https://www.topcoder.com/challenges/30093882 has been updated - it has been assigned to nauhil.

This is an automated message for thomaskranitsas via Topcoder X

nauhil commented 5 years ago

Due to spend lots of time for deploy AWS S3 locally, still cannot testing locally.

Open ticket for other members.

ThomasKranitsas commented 5 years ago

Contest https://www.topcoder.com/challenges/30093882 has been updated - it has been assigned to gurmeetb.

This is an automated message for thomaskranitsas via Topcoder X

codeMinter commented 5 years ago

@ThomasKranitsas when I click Edit on challenge, it redirects me back to HomePage with quick error screen. Can you suggest how to overcome this?

ThomasKranitsas commented 5 years ago

@gurmeetb you will have to create a new challenge and then click “view challenge”.

The current listings page is reading from v4 so those challenges don’t exist on v5

codeMinter commented 5 years ago

@ThomasKranitsas trying to push a new challenge, message: ""phases" must contain at least 1 items" is complained. I don't see phases in UI. I tried with F2F and Code

Edit: Setting up local backend so can by pass this backend issue.

nauhil commented 5 years ago

@ThomasKranitsas I have been set successfully S3 for testing. If @gurmeetb cannot finish it after 24hr. I can handle this ticket

codeMinter commented 5 years ago

@nauhil go ahead.

ThomasKranitsas commented 5 years ago

Contest https://www.topcoder.com/challenges/30093882 has been updated - it has been assigned to nauhil.

This is an automated message for thomaskranitsas via Topcoder X

nauhil commented 5 years ago

I follow the README.md file https://github.com/topcoder-platform/challenge-api/blob/develop/README.md

export AUTH0_CLIENT_ID=** export AUTH0_CLIENT_SECRET=** export AUTH0_URL=https://topcoder-dev.auth0.com/oauth/token export AUTH0_AUDIENCE=https://m2m.topcoder-dev.com/

I faced the error when I update challenge though POSTMAN Alt text

Did I miss something?

cwdcwd commented 5 years ago

looks correct. Does curling for token work?

curl --request POST \
  --url https://topcoder-dev.auth0.com/oauth/token \
  --header 'content-type: application/json' \
  --data '{"client_id":"***INSERT THE CLIENT ID HERE***","client_secret":"***INSERT THE CLIENT SECRET HERE***","audience":"https://m2m.topcoder-dev.com/","grant_type":"client_credentials"}' 
nauhil commented 5 years ago

Could I use action method instead of service method in component? https://github.com/topcoder-platform/challenge-engine-ui/blob/fe0dc620838a221013389e8a6b5daafb0b190095/src/components/ChallengeEditor/index.js#L89

I can not get challenge data from props, all data of challenge in state not props. It's not best practiceAlt text

nauhil commented 5 years ago

For Drag&Drop File Alt text

The component should be supported drag and drop.

Does this package acceptable https://react-dropzone.netlify.com/

nauhil commented 5 years ago

https://github.com/topcoder-platform/challenge-engine-ui/issues/68#issuecomment-504621561 https://github.com/topcoder-platform/challenge-engine-ui/issues/68#issuecomment-504650296

Both requirements have been finished.

One more thing, I think there should be displayed message like https://www.npmjs.com/package/react-redux-toastr when upload failure.

Any thoughts ?

ThomasKranitsas commented 5 years ago

Adding react-redux-toastr sounds good

nauhil commented 5 years ago

OK

Almost done. Fixing conflicts and prepare raise PR

ThomasKranitsas commented 5 years ago

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30093882

This is an automated message for thomaskranitsas via Topcoder X