Thomas' Review of Process

[rootelement]

Please review this comment: https://github.com/topcoder-platform/challenge-api/issues/312#issuecomment-719533821

Pulling out the important parts:

High Priority:

• [x] ⚠️ Create, save as draft, activate and try to close without any page refresh. I'm getting an error saying I need to assign a member even though I have already assigned the member
• [ ] 🔴 I have activated a challenge, then changed the spec from the WM. The frontend renders it as text instead of Markdown. Seems like the descriptionFormat is set to HTML. Not sure if that's during sync but it's breaking the spec layout.
• [ ] 🔴 Even before the above issue occurs, the frontend still doesn't render the spec properly. The following are not working: blockquote, My assumption is that this is happening because of the usage of xss which changes > to > making it invalid syntax.
  • I believe this is a two-part fix. We need to un-escape the > when displaying the markdown if we're to leave the xss in place. So that will have to happen on the WM side and the Community App side. @ThomasKranitsas can you PR this into Community App develop please?

Medium Priority:

• [ ] 🔴 I can notice some bad state management. I see data being reset in the state after saving or activating a challenge. Then I have to refresh to get it working properly.
• [ ] 🔴 There's no way to remove the reviewer?
• [ ] 🔴 There's no way to remove the copilot?

Low Priority:

• [ ] ⚠️ The Online Review button should only be visible if the legacyId exists otherwise it doesn't make sense to redirect you to the undefined challenge.
• [ ] ⚠️ Same for the Direct button.

[vikasrohit]

Create, save as draft, activate and try to close without any page refresh. I'm getting an error saying I need to assign a member even though I have already assigned the member

@ThomasKranitsas The reason for that is that we are verifying if task.memberId is set for the challenge before letting the task to be closed. If that field is not required by the backend for ensuring that task is assigned, we can validate the Submitter resource being present for the challenge.

I have activated a challenge, then changed the spec from the WM. The frontend renders it as text instead of Markdown. Seems like the descriptionFormat is set to HTML. Not sure if that's during sync but it's breaking the spec layout.

Yep, we noticed it earlier as well, however, we didn't find the root cause of it because the front end is never setting the descriptionFormat to anything other than markdown. So, we had impression that something in sync is causing this field to be overridden. Still, we can investigate it again.

I can notice some bad state management. I see data being reset in the state after saving or activating a challenge. Then I have to refresh to get it working properly.

Do we have concrete example or steps to reproduce the issue?

[vikasrohit]

Create, save as draft, activate and try to close without any page refresh. I'm getting an error saying I need to assign a member even though I have already assigned the member

It is done and deployed to prod. Verified.