topcoder-platform / work-manager

This is the frontend application for creating and managing challenges.
13 stars 47 forks source link

Reviewer Selection & Fee Conditional Logic #902

Open acshields opened 4 years ago

acshields commented 4 years ago

Update 1: Q/A Structure

Update 2: Conditional Logic Scenarios

Scenario 1 Pre-Conditions:

Scenario 2 Pre-Conditions:

Scenario 3 Pre-Conditions:

Scenario 4 Pre-Conditions:

Scenario 5 Pre-Conditions:

Scenario 6 Pre-Conditions:

vikasrohit commented 4 years ago

If the track selected is Data Science, the type is Challenge, and it is indicated that it will be a Marathon Match, then the default answer option selected should be: "Automated Review"

@acshields does that mean that user can select any of other review type for Marathon Match?

acshields commented 4 years ago

@vikasrohit - Yes, I spoke with Lazy on this yesterday. For Marathon Matches, Automated Review is the default. However, in some cases, delivery teams also choose to incorporate a Community Reviewer or Internal Reviewer into the process as well.

So, essentially, for all of our tracks, there will be a default answer. However, the user could choose to add in additional review types in Advanced Settings if desired.

vikasrohit commented 3 years ago

Thanks @acshields. I am moving it back to November project because as we discussed we have to start on all of the design updates (at least for the creation form) simultaneously. This issue is tightly coupled with https://github.com/topcoder-platform/work-manager/issues/736

maxceem commented 3 years ago
  1. What value should we save to the API into legacy.reviewType for Automated Review, automated?
vikasrohit commented 3 years ago

@rootelement help needed. :)

cwdcwd commented 3 years ago

call to https://api.topcoder.com/v5/reviewTypes?name=Automated%20Testing%20Review to get the Id of the review type for v5.

rootelement commented 3 years ago

@maxceem you don't need the ID, you should just be able to use the name. It looks in the legacy-challenge-processor like we're setting the default to INTERNAL, so the name should be fine. We'll have to test it in dev.