search

topcoderinc / dsp-frontend

React fronted to drone series
8 stars 23 forks source link

[50$] Eslint errors #8

Closed gondzo closed 7 years ago

gondzo commented 7 years ago

Running eslint produces 900+ errors that should be fixed.

lstkz commented 7 years ago

please assign to me

handle: Sky_

lstkz commented 7 years ago

see #9

lstkz commented 7 years ago

btw there are many duplicated components under different routes

lstkz commented 7 years ago

I would suggest merging eslint fixes to other branches, before doing any new contests. Otherwise, branch merges will be hard.

gondzo commented 7 years ago

With the updated eslintrc I get many 'Parse errors in imported module './XXYY.scss' import/no-named-as-default'. Adding '"settings":{"import/ignore":[".scss$"] }"' to eslintrc is correct ? Also, there are 132 'import/no-named-as-default' errors like 'Using exported name 'StatusDetailView' as identifier for default export import/no-named-as-default'

lstkz commented 7 years ago

can you remove node_modules and rerun npm i?

gondzo commented 7 years ago

That does it. Running lint fix to resolve line ending issues produces the above errors. Closing the issue.

kbowerma commented 7 years ago

Jira Payment record: https://apps.topcoder.com/bugs/browse/DRONESERIES-9