topcoderinc / va-kidney-ios

Mobile Kidney App for VA
2 stars 2 forks source link

As a user, I need to enter my profile information #17

Closed dustinWeaver closed 6 years ago

dustinWeaver commented 6 years ago

In the profile screen, the user should be able to enter/save the following:


These selections will be based on other parts of the system

chqy24 commented 6 years ago

currently, we already have a profile screen for editing user info: http://take.ms/kN3VC so the requirements here should be update this screen to show only those fields above, right?

dustinWeaver commented 6 years ago

For now it's just a prototype screen. So now we need to actually save / retrieve the values. In this case, we should use any data available in Healthkit.

seriyvolk83 commented 6 years ago

Actually everything in Profile is saved and retrieved. Profile data is persistent.

we should use any data available in Healthkit.

So, everything what can be saved to HealthKit should be saved there, correct?

Can you clarify what is "Dialysis indicator" (and what it affects in therms of data shown in the app and features the app provides)?

What are all possible options for "Disease Category"? These: "Stage 1, 2, 3a, 3b, 4, 5" ?

Option "Want to setup goals?": If user sets "Yes", then we use the entered data and CKD Common Goals table to generate a ready to use list of goals? Correct?

"Add Biometric Device":

dustinWeaver commented 6 years ago

Answers below:

Biometric Device

seriyvolk83 commented 6 years ago

In hindsight, perhaps we should remove this all together and have our app ask for HealthKit access at the first startup?

That will be better. However, if user will deny, then some screens will not work, e.g. Charts. (this is normal).

dustinWeaver commented 6 years ago

Maybe we could have a friendly screen to explain that the user needs to answer "yes" in order for the app to work?

seriyvolk83 commented 6 years ago

The standard HealthKit request will show our custom (configurable) message. No need to extra screens or dialogs. I informed that user can deny access in any moment (during initial authorization request) or later in Setting app.

dustinWeaver commented 6 years ago

Ah, ok. Thank you!

seriyvolk83 commented 6 years ago

ask for HealthKit access at the first startup?

It's better to do that right after Sign In when user enters into the app. Correct?

seriyvolk83 commented 6 years ago

I reviewing your answer and not sure about the following

Correct on "Setup goals"

Did you mean we need to change the title from "Want to setup goals?" to "Setup goals" or you confirmed that we need to generate goals based on current Disease Category? Or may be both?

seriyvolk83 commented 6 years ago

The goals in tabs "Common Goals" and "Goals" do not match to each other (see "meat meals"). I assume we need to follow second tab ("Goals"). Correct? https://docs.google.com/spreadsheets/d/1i9zAvFV17Q22VWIlsnzuz75V4FFNybFh1oAaD5m1mxk/edit#gid=1055030748

Please do not modify the table. It can be fixed later (if there is issue).

seriyvolk83 commented 6 years ago

@talesforce I assume the above is correct. Also, I found that current UI for adding goals cannot be used to limit user from selecting goals from the list that correspond to the disease. The automatic goal generation based on the disease will work as expected, but user is able to add goals as before. I assume we can fix the UI later after requirements will be more clear.

talesforce commented 6 years ago

Yes, confirmed

On Sun, Mar 4, 2018 at 7:45 PM, seriyvolk83 notifications@github.com wrote:

@talesforce https://github.com/talesforce I assume the above is correct. Also, I found that current UI for adding goals cannot be used to limit user from selecting goals from the list that correspond to the disease. The automatic goal generation based on the disease will work as expected, but user is able to add goals as before. I assume we can fix the UI later after requirements will be more clear.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/topcoderinc/va-kidney-ios/issues/17#issuecomment-370232441, or mute the thread https://github.com/notifications/unsubscribe-auth/AB7vcRQWy_ts3qaRvVHxOMOqGhIuPRPRks5ta_cIgaJpZM4ST4LU .

--

Regards,

Talesforce Co-pilot/ Reviewer/ Ex-Community Advisory Board talesforce@topcoder.com / admin@talesforce.com

www.topcoder.com http://topcoder.com/ / topcoder.com/blog / @Topcoder https://twitter.com/topcoder 760 Market Street, 11th Floor, San Francisco, CA 94102

sdgun commented 6 years ago
seriyvolk83 commented 6 years ago

@talesforce What should be done here? Looks like all work.

seriyvolk83 commented 6 years ago

@sdgun

No real data for Goal setup access yet...

"Setup goals" is just a flag. If set to "Yes", then goals are generated automatically based on "Disease Category" and "Are you on Dialysis" flag. This already works.

seriyvolk83 commented 6 years ago

related to #25

talesforce commented 6 years ago

@sdgun - Can you please clarify what is the issue you are facing on this screen?

sdgun commented 6 years ago

@seriyvolk83 @talesforce It works

talesforce commented 6 years ago

Closing this issue